chrome/test/BUILD.gn - Issue 2063503002: Make large test_support targets static libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 2063503002: Make large test_support targets static libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 2bd9bc3fabb7131cbbddb00ddff8f7d1b2d9543b..be8f0f9fae4172ac5e453b9418266d15489afccd 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -23,7 +23,10 @@ group("test") {

}

# GYP version: chrome/chrome_tests_unit.gypi:test_support_common

-source_set("test_support") {

+# Use a static library here because many test binaries depend on this but don't

+# require many files from it. This makes linking more efficient.

+static_library("test_support") {

defines = []

testonly = true

« no previous file with comments | « chrome/common/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »