Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/BUILD.gn

Issue 2063483002: Make chrome/browser and .../ui static libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 388532475c91952f7f5beda1a2527b648d08679e..fe59bcdfdb7e38b9c966af078ff163af8271bae7 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -78,7 +78,17 @@ if (is_desktop_linux) {
}
}
-source_set("browser") {
+# Use a static library here because many test binaries depend on this but don't
+# require many files from it. This makes linking more efficient.
+if (is_mac) {
+ # TODO(brettw) bug 618797: On Mac making this target a static_library causes
+ # a crash on startup and the browser_tests all fail. My guess is this is due
+ # to a required static initializer not being brought in.
+ chrome_browser_target_type = "source_set"
+} else {
+ chrome_browser_target_type = "static_library"
+}
+target(chrome_browser_target_type, "browser") {
configs += [
"//build/config/compiler:wexit_time_destructors",
"//build/config:precompiled_headers",
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698