Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: chrome/browser/BUILD.gn

Issue 2063483002: Make chrome/browser and .../ui static libraries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//chrome/common/features.gni") 9 import("//chrome/common/features.gni")
10 import("//media/media_options.gni") 10 import("//media/media_options.gni")
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 # If you want to link gnome-keyring directly (use only for unit tests) 71 # If you want to link gnome-keyring directly (use only for unit tests)
72 # ADDITIONALLY add this config on top of ":gnome_keyring". pkg-config is a 72 # ADDITIONALLY add this config on top of ":gnome_keyring". pkg-config is a
73 # bit slow, so prefer not to run it again. In practice, gnome-keyring's libs 73 # bit slow, so prefer not to run it again. In practice, gnome-keyring's libs
74 # are just itself and common gnome ones we link already, so we can get away 74 # are just itself and common gnome ones we link already, so we can get away
75 # with additionally just coding the library name here. 75 # with additionally just coding the library name here.
76 config("gnome_keyring_direct") { 76 config("gnome_keyring_direct") {
77 libs = [ "gnome-keyring" ] 77 libs = [ "gnome-keyring" ]
78 } 78 }
79 } 79 }
80 80
81 source_set("browser") { 81 # Use a static library here because many test binaries depend on this but don't
82 # require many files from it. This makes linking more efficient.
83 if (is_mac) {
84 # TODO(brettw) bug 618797: On Mac making this target a static_library causes
85 # a crash on startup and the browser_tests all fail. My guess is this is due
86 # to a required static initializer not being brought in.
87 chrome_browser_target_type = "source_set"
88 } else {
89 chrome_browser_target_type = "static_library"
90 }
91 target(chrome_browser_target_type, "browser") {
82 configs += [ 92 configs += [
83 "//build/config/compiler:wexit_time_destructors", 93 "//build/config/compiler:wexit_time_destructors",
84 "//build/config:precompiled_headers", 94 "//build/config:precompiled_headers",
85 "//third_party/WebKit/public:debug_devtools", 95 "//third_party/WebKit/public:debug_devtools",
86 ] 96 ]
87 defines = [] 97 defines = []
88 sources = [] 98 sources = []
89 libs = [] 99 libs = []
90 ldflags = [] 100 ldflags = []
91 101
(...skipping 1261 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 # linking all of the test support. 1363 # linking all of the test support.
1354 source_set("pepper_cdm_test_constants") { 1364 source_set("pepper_cdm_test_constants") {
1355 testonly = true 1365 testonly = true
1356 visibility = [ "//chrome/*" ] 1366 visibility = [ "//chrome/*" ]
1357 sources = [ 1367 sources = [
1358 "media/pepper_cdm_test_constants.cc", 1368 "media/pepper_cdm_test_constants.cc",
1359 "media/pepper_cdm_test_constants.h", 1369 "media/pepper_cdm_test_constants.h",
1360 ] 1370 ]
1361 } 1371 }
1362 } 1372 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698