Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2062593002: Revert of Fix scope flags for default parameters (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix scope flags for default parameters (patchset #2 id:20001 of https://codereview.chromium.org/2042793002/ ) Reason for revert: Does not fix the bug it intended to fix. Original issue's description: > Fix scope flags for default parameters > > R=rossberg,adamk > BUG=chromium:616386 > > Committed: https://crrev.com/4cc1331c341f5bfbeee54fec521f682a8a406af4 > Cr-Commit-Position: refs/heads/master@{#36755} TBR=adamk@chromium.org,rossberg@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:616386 Committed: https://crrev.com/78bb3c6ef99fb9149923056b1b25d2a8859e10b7 Cr-Commit-Position: refs/heads/master@{#36976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/parsing/parser.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dan Ehrenberg
Created Revert of Fix scope flags for default parameters
4 years, 6 months ago (2016-06-11 00:52:53 UTC) #2
adamk
Reverting seems lgtm if this doesn't actually fix the problem.
4 years, 6 months ago (2016-06-14 09:57:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062593002/1
4 years, 6 months ago (2016-06-14 16:11:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 16:46:39 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 16:49:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78bb3c6ef99fb9149923056b1b25d2a8859e10b7
Cr-Commit-Position: refs/heads/master@{#36976}

Powered by Google App Engine
This is Rietveld 408576698