Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2042793002:
Fix scope flags for default parameters (Closed)
|
Created:
4 years, 6 months ago by Dan Ehrenberg Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFix scope flags for default parameters
R=rossberg,adamk
BUG=chromium:616386
Committed: https://crrev.com/4cc1331c341f5bfbeee54fec521f682a8a406af4
Cr-Commit-Position: refs/heads/master@{#36755}
Patch Set 1 #Patch Set 2 : Another propagate call #
Total comments: 2
Messages
Total messages: 18 (7 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042793002/1
jochen@chromium.org changed reviewers: + jochen@chromium.org
test?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042793002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042793002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix scope flags for default parameters R=rossberg,adamk BUG=chromium:616386 ========== to ========== Fix scope flags for default parameters R=rossberg,adamk BUG=chromium:616386 Committed: https://crrev.com/4cc1331c341f5bfbeee54fec521f682a8a406af4 Cr-Commit-Position: refs/heads/master@{#36755} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4cc1331c341f5bfbeee54fec521f682a8a406af4 Cr-Commit-Position: refs/heads/master@{#36755}
Message was sent while issue was closed.
Thanks for the quick fix! Commented on the bug, but figured I'd leave comments here too. https://codereview.chromium.org/2042793002/diff/20001/src/parsing/parser.cc File src/parsing/parser.cc (right): https://codereview.chromium.org/2042793002/diff/20001/src/parsing/parser.cc#n... src/parsing/parser.cc:4605: scope_->PropagateUsageFlagsToScope(param_scope); This is where we have to make the call, so that the call to FinalizeBlockScope below doesn't over-eagerly remove this scope from the scope chain. https://codereview.chromium.org/2042793002/diff/20001/src/parsing/parser.cc#n... src/parsing/parser.cc:4628: scope_->PropagateUsageFlagsToScope(param_scope); This call is now redundant, right?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2062593002/ by littledan@chromium.org. The reason for reverting is: Does not fix the bug it intended to fix.. |
