Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Post dmurph review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
new file mode 100644
index 0000000000000000000000000000000000000000..ebcbda061c81a062dfa088f9ac45606b627c3479
--- /dev/null
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h
@@ -0,0 +1,35 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WebIDBObserverImpl_h
+#define WebIDBObserverImpl_h
+
+// TODO(palakj): header to include for persistent?
Marijn Kruisselbrink 2016/06/28 18:58:31 that would be platform/heap/Persistent.h?
palakj1 2016/06/29 23:02:41 Done.
+#include "public/platform/WebPrivatePtr.h"
Marijn Kruisselbrink 2016/06/28 18:58:31 I don't think you're using this header?
palakj1 2016/06/29 23:02:41 Removed.
+#include "public/platform/modules/indexeddb/WebIDBObserver.h"
+#include <memory>
Marijn Kruisselbrink 2016/06/28 18:58:31 I don't think you're using this header either?
palakj1 2016/06/29 23:02:41 Removed.
+
+namespace blink {
+
+class IDBObserver;
+
+class WebIDBObserverImpl final : public WebIDBObserver {
+ USING_FAST_MALLOC(WebIDBObserverImpl);
+
+public:
+ static std::unique_ptr<WebIDBObserverImpl> create(IDBObserver*);
+
+ ~WebIDBObserverImpl() override;
+
+ void removeObserver(int32_t id) override;
+
+private:
+ explicit WebIDBObserverImpl(IDBObserver*);
+
+ Persistent<IDBObserver> m_observer;
+};
+
+} // namespace blink
+
+#endif // WebIDBObserverImpl_h

Powered by Google App Engine
This is Rietveld 408576698