Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Post dmurph review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef WebIDBObserverImpl_h
6 #define WebIDBObserverImpl_h
7
8 // TODO(palakj): header to include for persistent?
Marijn Kruisselbrink 2016/06/28 18:58:31 that would be platform/heap/Persistent.h?
palakj1 2016/06/29 23:02:41 Done.
9 #include "public/platform/WebPrivatePtr.h"
Marijn Kruisselbrink 2016/06/28 18:58:31 I don't think you're using this header?
palakj1 2016/06/29 23:02:41 Removed.
10 #include "public/platform/modules/indexeddb/WebIDBObserver.h"
11 #include <memory>
Marijn Kruisselbrink 2016/06/28 18:58:31 I don't think you're using this header either?
palakj1 2016/06/29 23:02:41 Removed.
12
13 namespace blink {
14
15 class IDBObserver;
16
17 class WebIDBObserverImpl final : public WebIDBObserver {
18 USING_FAST_MALLOC(WebIDBObserverImpl);
19
20 public:
21 static std::unique_ptr<WebIDBObserverImpl> create(IDBObserver*);
22
23 ~WebIDBObserverImpl() override;
24
25 void removeObserver(int32_t id) override;
26
27 private:
28 explicit WebIDBObserverImpl(IDBObserver*);
29
30 Persistent<IDBObserver> m_observer;
31 };
32
33 } // namespace blink
34
35 #endif // WebIDBObserverImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698