third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h - Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Post dmurph review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h ('K') | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBObserver.h » ('j') | third_party/WebKit/public/platform/modules/indexeddb/WebIDBObserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

index 4752309714966285f5562d8b948b18b27db9cc06..481f05d02374dbda073949b2151afca2b5b58389 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h

@@ -30,7 +30,10 @@

#include "public/platform/WebCommon.h"

#include "public/platform/modules/indexeddb/WebIDBCursor.h"

#include "public/platform/modules/indexeddb/WebIDBMetadata.h"

+#include "public/platform/modules/indexeddb/WebIDBObserver.h"

#include "public/platform/modules/indexeddb/WebIDBTypes.h"

+#include <set>

+#include <vector>

namespace blink {

@@ -40,6 +43,7 @@ class WebIDBDatabaseCallbacks;

class WebIDBKey;

class WebIDBKeyPath;

class WebIDBKeyRange;

+class WebIDBObserver;

class WebIDBDatabase {

public:

@@ -61,6 +65,10 @@ public:

typedef WebVector<WebIDBKey> WebIndexKeys;

+ virtual int32_t addObserver(WebIDBObserver*, long long transactionId) = 0;

Marijn Kruisselbrink 2016/06/28 18:58:31 You seem to be transferring ownership of the WebID

palakj1 2016/06/29 23:02:41 Had been imitating the existing code, but changes

+ virtual bool containsObserverId(int32_t id) = 0;

+ // rename this.

dmurph 2016/06/28 18:53:50 nit: remove this comment.

Marijn Kruisselbrink 2016/06/28 18:58:31 Remove the comment and/or rename whatever you want

palakj1 2016/06/29 23:02:41 Done.

+ virtual void removeObservers(const std::vector<int32_t>& observerIdsToRemove) = 0;

virtual void get(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, bool keyOnly, WebIDBCallbacks*) = 0;

virtual void getAll(long long transactionId, long long objectStoreId, long long indexId, const WebIDBKeyRange&, long long maxCount, bool keyOnly, WebIDBCallbacks*) = 0;

virtual void put(long long transactionId, long long objectStoreId, const WebData& value, const WebVector<WebBlobInfo>&, const WebIDBKey&, WebIDBPutMode, WebIDBCallbacks*, const WebVector<long long>& indexIds, const WebVector<WebIndexKeys>&) = 0;