IDBObserver: Lifetime Management: Adding Observer

content/common/indexed_db/indexed_db_messages.h

Index: content/common/indexed_db/indexed_db_messages.h
diff --git a/content/common/indexed_db/indexed_db_messages.h b/content/common/indexed_db/indexed_db_messages.h
index 68af020df66f3263d23be24d53fb28527371c7ed..a33312d817d9b3c4173b7f768e92cf8e7a5e469e 100644
--- a/content/common/indexed_db/indexed_db_messages.h
+++ b/content/common/indexed_db/indexed_db_messages.h
@@ -111,6 +111,16 @@ IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseCreateObjectStore_Params)
   IPC_STRUCT_MEMBER(bool, auto_increment)
 IPC_STRUCT_END()
 
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseObserve_Params)
+  IPC_STRUCT_MEMBER(int32_t, ipc_thread_id)
+  // The database the object store belongs to.
+  IPC_STRUCT_MEMBER(int32_t, ipc_database_id)
+  // The transaction id as minted by the frontend.
+  IPC_STRUCT_MEMBER(int64_t, transaction_id)
+  // The observer id.
+  IPC_STRUCT_MEMBER(int64_t, observer_id)

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

if we actually require the observer_id to be 32 bit it seems a bit weird to send
it over as a 64 bit integer. Although I must say I don't quite understand all
the ID magic yet.

[palakj1, 2016/06/16 07:05:41]

Changed

+IPC_STRUCT_END()
+
 IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseGet_Params)
   IPC_STRUCT_MEMBER(int32_t, ipc_thread_id)
   // The id any response should contain.
@@ -489,6 +499,10 @@ IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_AckReceivedBlobs,
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_DatabaseCreateObjectStore,
                      IndexedDBHostMsg_DatabaseCreateObjectStore_Params)
 
+// WebIDBDatabase::observe() message.
+IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_DatabaseObserve,
+                     IndexedDBHostMsg_DatabaseObserve_Params)

[dmurph, 2016/06/15 12:49:44]

Probably don't need the params struct as we just have 4 items to send.

[palakj1, 2016/06/16 07:05:41]

Done

+

[dmurph, 2016/06/15 12:49:44]

Also add a message to remove the observer, which has the thread_id, database_id,
and observer_id

 // WebIDBDatabase::deleteObjectStore() message.
 IPC_MESSAGE_CONTROL3(IndexedDBHostMsg_DatabaseDeleteObjectStore,
                      int32_t, /* ipc_database_id */