IDBObserver: Lifetime Management: Adding Observer

content/common/indexed_db/indexed_db_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include <stdint.h>
 
 #include <string>
 #include <utility>
@@ skipping 93 matching lines @@
   // The storage id of the object store.
   IPC_STRUCT_MEMBER(int64_t, object_store_id)
   // The name of the object store.
   IPC_STRUCT_MEMBER(base::string16, name)
   // The keyPath of the object store.
   IPC_STRUCT_MEMBER(content::IndexedDBKeyPath, key_path)
   // Whether the object store created should have a key generator.
   IPC_STRUCT_MEMBER(bool, auto_increment)
 IPC_STRUCT_END()
 
+IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseObserve_Params)
+  IPC_STRUCT_MEMBER(int32_t, ipc_thread_id)
+  // The database the object store belongs to.
+  IPC_STRUCT_MEMBER(int32_t, ipc_database_id)
+  // The transaction id as minted by the frontend.
+  IPC_STRUCT_MEMBER(int64_t, transaction_id)
+  // The observer id.
+  IPC_STRUCT_MEMBER(int64_t, observer_id)

[Marijn Kruisselbrink, 2016/06/15 13:14:57]

if we actually require the observer_id to be 32 bit it seems a bit weird to send
it over as a 64 bit integer. Although I must say I don't quite understand all
the ID magic yet.

[palakj1, 2016/06/16 07:05:41]

Changed

+IPC_STRUCT_END()
+
 IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseGet_Params)
   IPC_STRUCT_MEMBER(int32_t, ipc_thread_id)
   // The id any response should contain.
   IPC_STRUCT_MEMBER(int32_t, ipc_callbacks_id)
   // The database the object store belongs to.
   IPC_STRUCT_MEMBER(int32_t, ipc_database_id)
   // The transaction its associated with.
   IPC_STRUCT_MEMBER(int64_t, transaction_id)
   // The object store's id.
   IPC_STRUCT_MEMBER(int64_t, object_store_id)
@@ skipping 358 matching lines @@
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_FactoryDeleteDatabase,
                      IndexedDBHostMsg_FactoryDeleteDatabase_Params)
 
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_AckReceivedBlobs,
                      std::vector<std::string>) /* uuids */
 
 // WebIDBDatabase::createObjectStore() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_DatabaseCreateObjectStore,
                      IndexedDBHostMsg_DatabaseCreateObjectStore_Params)
 
+// WebIDBDatabase::observe() message.
+IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_DatabaseObserve,
+                     IndexedDBHostMsg_DatabaseObserve_Params)

[dmurph, 2016/06/15 12:49:44]

Probably don't need the params struct as we just have 4 items to send.

[palakj1, 2016/06/16 07:05:41]

Done

+

[dmurph, 2016/06/15 12:49:44]

Also add a message to remove the observer, which has the thread_id, database_id,
and observer_id

 // WebIDBDatabase::deleteObjectStore() message.
 IPC_MESSAGE_CONTROL3(IndexedDBHostMsg_DatabaseDeleteObjectStore,
                      int32_t, /* ipc_database_id */
                      int64_t, /* transaction_id */
                      int64_t) /* object_store_id */
 
 // WebIDBDatabase::createTransaction() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_DatabaseCreateTransaction,
                      IndexedDBHostMsg_DatabaseCreateTransaction_Params)
 
@@ skipping 69 matching lines @@
                      int64_t) /* transaction_id */
 
 // WebIDBDatabase::commit() message.
 IPC_MESSAGE_CONTROL2(IndexedDBHostMsg_DatabaseCommit,
                      int32_t, /* ipc_database_id */
                      int64_t) /* transaction_id */
 
 // WebIDBDatabase::~WebIDBCursor() message.
 IPC_MESSAGE_CONTROL1(IndexedDBHostMsg_CursorDestroyed,
                      int32_t /* ipc_cursor_id */)