IDBObserver: Lifetime Management: Adding Observer

content/child/indexed_db/webidbdatabase_impl.h

Index: content/child/indexed_db/webidbdatabase_impl.h
diff --git a/content/child/indexed_db/webidbdatabase_impl.h b/content/child/indexed_db/webidbdatabase_impl.h
index 7d214bbd6c51f50ea8c7e7aeab5b3c6f8c7f530b..5b04f6bf7205b61217013dadd9399cb1a51c495c 100644
--- a/content/child/indexed_db/webidbdatabase_impl.h
+++ b/content/child/indexed_db/webidbdatabase_impl.h
@@ -13,6 +13,7 @@
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
 
 namespace blink {
+class IDBObserver;
 class WebBlobInfo;
 class WebIDBCallbacks;
 class WebIDBDatabaseCallbacks;
@@ -45,6 +46,8 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {
   void close() override;
   void versionChangeIgnored() override;
 

[dmurph, 2016/06/15 12:49:44]

You'll also want to store a collection (vector is fine) of observe ids, which we
then give to the dispatcher when 'close' is called.

[palakj1, 2016/06/16 07:05:41]

Is it okay to introduce a vector and do something concrete in WebIDB layer? The
layer seems to only channel IDBdatabase calls to dispatcher and nothing more.
Just a question of our convention.

+  void observe(blink::IDBObserver* observer, long long transactionId) override;
+
   void get(long long transactionId,
            long long objectStoreId,
            long long indexId,