IDBObserver: Lifetime Management: Adding Observer

content/child/indexed_db/webidbdatabase_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_
 #define CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_
 
 #include <stdint.h>
 
 #include "base/memory/ref_counted.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBTypes.h"
 
 namespace blink {
+class IDBObserver;
 class WebBlobInfo;
 class WebIDBCallbacks;
 class WebIDBDatabaseCallbacks;
 class WebString;
 }
 
 namespace content {
 class ThreadSafeSender;
 
 class WebIDBDatabaseImpl : public blink::WebIDBDatabase {
@@ skipping 11 matching lines @@
                          bool auto_increment) override;
   void deleteObjectStore(long long transaction_id,
                          long long object_store_id) override;
   void createTransaction(long long transaction_id,
                          blink::WebIDBDatabaseCallbacks* callbacks,
                          const blink::WebVector<long long>& scope,
                          blink::WebIDBTransactionMode mode) override;
 
   void close() override;
   void versionChangeIgnored() override;
 

[dmurph, 2016/06/15 12:49:44]

You'll also want to store a collection (vector is fine) of observe ids, which we
then give to the dispatcher when 'close' is called.

[palakj1, 2016/06/16 07:05:41]

Is it okay to introduce a vector and do something concrete in WebIDB layer? The
layer seems to only channel IDBdatabase calls to dispatcher and nothing more.
Just a question of our convention.

+  void observe(blink::IDBObserver* observer, long long transactionId) override;
+
   void get(long long transactionId,
            long long objectStoreId,
            long long indexId,
            const blink::WebIDBKeyRange&,
            bool keyOnly,
            blink::WebIDBCallbacks*) override;
   void getAll(long long transactionId,
               long long objectStoreId,
               long long indexId,
               const blink::WebIDBKeyRange&,
@@ skipping 54 matching lines @@
 
  private:
   int32_t ipc_database_id_;
   int32_t ipc_database_callbacks_id_;
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_INDEXED_DB_WEBIDBDATABASE_IMPL_H_