Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2062133004: Revert of Refactoring of GPU NormalMap handling out into its own class (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
reed1, dvonbeck
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Refactoring of GPU NormalMap handling out into its own class (patchset #7 id:120001 of https://codereview.chromium.org/2043393002/ ) Reason for revert: Breaking build and deps roll. Need to move include of SkBitmapProcShader in SkLightingShader.cpp from gpu include list to general list. Original issue's description: > Refactoring of GPU NormalMap handling out into its own class. > > The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources. > > What this CL includes: > > - Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP. > > - Encapsulates this new fragment processor on a new class NormalMapSource. > > - Created a NormalSource abstraction that will interface with SkLightingShader. > > - Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002 > > Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da TBR=reed@google.com,dvonbeck@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/da743935fa0aba854a96654a474454b09e5488e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -460 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkLightingShader.h View 1 chunk +0 lines, -52 lines 0 comments Download
M src/core/SkLightingShader.cpp View 15 chunks +115 lines, -62 lines 0 comments Download
D src/core/SkLightingShader_NormalSource.cpp View 1 chunk +0 lines, -290 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/SerializationTest.cpp View 4 chunks +2 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Refactoring of GPU NormalMap handling out into its own class
4 years, 6 months ago (2016-06-14 22:29:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062133004/1
4 years, 6 months ago (2016-06-14 22:30:01 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 22:30:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/da743935fa0aba854a96654a474454b09e5488e8

Powered by Google App Engine
This is Rietveld 408576698