Fix SkImage::asLegacyBitmap() to respect color space info

Fix SkImage::asLegacyBitmap() to respect color space info

BUG=skia:5428
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002

Committed: https://skia.googlesource.com/skia/+/be36d59e664513294c02ff9691a3c1817a712fee

[msarett, 2016-06-13 16:43:00]

Description was changed from

==========
Fix SkImage::asLegacyBitmap() to respect color space info

BUG=skia:5428
==========

to

==========
Fix SkImage::asLegacyBitmap() to respect color space info

BUG=skia:5428
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002
==========

[msarett, 2016-06-13 16:47:06]

Patchset #1 (id:1) has been deleted

[msarett, 2016-06-13 17:02:03]

msarett@google.com changed reviewers:
+ liyuqian@google.com

[msarett, 2016-06-13 17:02:03]

This reproduces and fixes at least *some* of the issues we saw.

[liyuqian, 2016-06-13 17:32:30]

On 2016/06/13 17:02:03, msarett wrote:
> This reproduces and fixes at least *some* of the issues we saw.

LGTM with a little nit. But I'm not an expert of SkImage...

[reed1, 2016-06-13 17:34:39]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-06-13 17:34:39]

lgtm

[msarett, 2016-06-13 17:38:23]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-06-13 17:38:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061783002/40001

[liyuqian, 2016-06-13 17:39:02]

Forget to publish my comments...

https://codereview.chromium.org/2061783002/diff/40001/gm/bitmapimage.cpp
File gm/bitmapimage.cpp (right):

https://codereview.chromium.org/2061783002/diff/40001/gm/bitmapimage.cpp#newc...
gm/bitmapimage.cpp:51: // The top two squares show an sRGB image, then bitmap,
drawn to a srgb canvas.
The "bottom" two squares...?

[msarett, 2016-06-13 17:39:24]

The CQ bit was unchecked by msarett@google.com

[msarett, 2016-06-13 17:40:31]

https://codereview.chromium.org/2061783002/diff/40001/gm/bitmapimage.cpp
File gm/bitmapimage.cpp (right):

https://codereview.chromium.org/2061783002/diff/40001/gm/bitmapimage.cpp#newc...
gm/bitmapimage.cpp:51: // The top two squares show an sRGB image, then bitmap,
drawn to a srgb canvas.
On 2016/06/13 17:39:02, liyuqian wrote:
> The "bottom" two squares...?

Aaah thanks.  Done.

[msarett, 2016-06-13 17:40:49]

The CQ bit was checked by msarett@google.com

[msarett, 2016-06-13 17:40:49]

The patchset sent to the CQ was uploaded after l-g-t-m from liyuqian@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2061783002/#ps60001
(title: "Fix nit")

[commit-bot: I haz the power, 2016-06-13 17:41:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061783002/60001

[commit-bot: I haz the power, 2016-06-13 17:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 17:53:31]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[msarett, 2016-06-13 18:05:22]

The CQ bit was checked by msarett@google.com

[msarett, 2016-06-13 18:05:23]

The patchset sent to the CQ was uploaded after l-g-t-m from liyuqian@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2061783002/#ps80001
(title: "Fix windows")

[commit-bot: I haz the power, 2016-06-13 18:05:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061783002/80001

[commit-bot: I haz the power, 2016-06-13 18:25:05]

Description was changed from

==========
Fix SkImage::asLegacyBitmap() to respect color space info

BUG=skia:5428
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002
==========

to

==========
Fix SkImage::asLegacyBitmap() to respect color space info

BUG=skia:5428
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002

Committed:
https://skia.googlesource.com/skia/+/be36d59e664513294c02ff9691a3c1817a712fee
==========

[commit-bot: I haz the power, 2016-06-13 18:25:06]

Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/be36d59e664513294c02ff9691a3c1817a712fee