Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: gm/bitmapimage.cpp

Issue 2061783002: Fix SkImage::asLegacyBitmap() to respect color space info (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix windows Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/image/SkImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/bitmapimage.cpp
diff --git a/gm/bitmapimage.cpp b/gm/bitmapimage.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..ad6a74dda86a561154a19502edd7f5727a3acdbd
--- /dev/null
+++ b/gm/bitmapimage.cpp
@@ -0,0 +1,73 @@
+/*
+ * Copyright 2016 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "gm.h"
+#include "Resources.h"
+
+namespace skiagm {
+
+class BitmapImageGM : public GM {
+public:
+ BitmapImageGM() {}
+
+protected:
+
+ SkString onShortName() override {
+ return SkString("bitmap-image-srgb-linear");
+ }
+
+ SkISize onISize() override {
+ return SkISize::Make(2*kSize, 2*kSize);
+ }
+
+ void onDraw(SkCanvas* canvas) override {
+ // Create image.
+ sk_sp<SkImage> image = GetResourceAsImage("mandrill_512_q075.jpg");
+ if (!image) {
+ SkDebugf("Failure: Is the resource path set properly?");
+ return;
+ }
+
+ // Create matching bitmap.
+ SkBitmap bitmap;
+ SkAssertResult(image->asLegacyBitmap(&bitmap, SkImage::kRO_LegacyBitmapMode));
+
+ // The GM will be displayed in a 2x2 grid.
+ // The top two squares show an sRGB image, then bitmap, drawn to a linear canvas.
+ SkImageInfo linearInfo = SkImageInfo::MakeN32(2*kSize, kSize, kOpaque_SkAlphaType);
+ SkBitmap linearBMCanvas;
+ linearBMCanvas.allocPixels(linearInfo);
+ SkCanvas linearCanvas(linearBMCanvas);
+ linearCanvas.drawImage(image, 0.0f, 0.0f, nullptr);
+ linearCanvas.translate(SkScalar(kSize), 0.0f);
+ linearCanvas.drawBitmap(bitmap, 0.0f, 0.0f, nullptr);
+ canvas->drawBitmap(linearBMCanvas, 0.0f, 0.0f, nullptr);
+ canvas->translate(0.0f, SkScalar(kSize));
+
+ // The bottom two squares show an sRGB image, then bitmap, drawn to a srgb canvas.
+ SkImageInfo srgbInfo = SkImageInfo::MakeS32(2*kSize, kSize, kOpaque_SkAlphaType);
+ SkBitmap srgbBMCanvas;
+ srgbBMCanvas.allocPixels(srgbInfo);
+ SkCanvas srgbCanvas(srgbBMCanvas);
+ srgbCanvas.drawImage(image, 0.0f, 0.0f, nullptr);
+ srgbCanvas.translate(SkScalar(kSize), 0.0f);
+ srgbCanvas.drawBitmap(bitmap, 0.0f, 0.0f, nullptr);
+ canvas->drawBitmap(srgbBMCanvas, 0.0f, 0.0f, nullptr);
+ }
+
+private:
+ static constexpr int kSize = 512;
+
+ typedef GM INHERITED;
+};
+
+//////////////////////////////////////////////////////////////////////////////
+
+static GM* MyFactory(void*) { return new BitmapImageGM; }
+static GMRegistry reg(MyFactory);
+
+}
« no previous file with comments | « no previous file | src/image/SkImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698