Implementation of Device End of Life Notification

Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec
Cr-Commit-Position: refs/heads/master@{#400578}

[xiaoyinh(OOO Sep 11-29), 2016-06-10 23:22:48]

Description was changed from

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual
==========

to

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2016-06-16 20:54:27]

xiaoyinh@chromium.org changed reviewers:
+ isherman@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

[xiyuan, 2016-06-16 22:41:29]

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5776: <message
name="IDS_ABOUT_PAGE_EOL_SECURITY_ONLY" desc="The message for eol security
only">
nit: The "desc" attribute is what our translators see and probably the only
context they have. It would be great to put in detailed info in addition to the
message text itself so that they know where the message is used and for what
purpose.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5789: <ph name="BEGIN_LINK_EOL">&lt;a
target="_blank" href="$1"&gt;</ph>  More info<ph
name="END_LINK_EOL">&lt;/a&gt;</ph>
Are the two spaces before "More info" on purpose? Why do we need to include it
as part of the link? If it is intentional, we might consider using &nbsp;
instead of plain space.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5792: More info
nit: wrong indent?

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5795: Enable Device End of Lfe notification.
nit: Lfe -> Life

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5801: 
nit: get rid of one empty line

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:10: #include
"chrome/browser/chromeos/eol_notification.h"
Make this the first include and insert a space after it. Then followed by C
headers, C++ headers, then chromium headers.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:31: #include
"ui/message_center/notification_delegate.h"
Clean up the includes and remove the unused ones, e.g. bind.h, bind_helper.h etc

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:53: Profile* profile_;
nit: Profile* const profile_; if it never changes during the lifetime of the
object.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:96: void EolNotification::Update() {
Move this down to match its order in the header file.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:114: void
EolNotification::GetEolStatus() {
nit: GetEolStatus -> CheckEolStatus seems more fit what it actually does.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:126: int pre_eol_status =
profile_->GetPrefs()->GetInteger(prefs::kEolStatus);
nit: const int

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.h (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:8: #include "base/callback.h"
not used?

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:18: class EolNotification {
Brief comment to document the class.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:27: Profile* profile_;
Members at the end in a section, after all methods.

https://google.github.io/styleguide/cppguide.html#Declaration_Order

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:27: Profile* profile_;
nit: Profile* const profile_;

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:36: int status_;
Move it to last. And initialize it with some value.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:39: base::string16 GetEolMessage();
#include "base/strings/string16.h"

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:22: #include
"chrome/browser/chromeos/eol_notification.h"
Forward clear in line 49 is enough, move the include to cc file.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:29: #include
"chromeos/dbus/update_engine_client.h"
Do we need this?

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:259:
std::unique_ptr<EolNotification> eol_notification_;
This does not feel belong here. It is user session/profile specific. Doing it
like this does not work for multi profile case.

Think it should be part of UserSessionManager and associated with its profile
similar to |default_ime_states_|.

Or better yet, make this a KeyedService so that every profile could have an
instance of it.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:24: #include
"chrome/browser/chromeos/eol_notification.h"
seems not needed.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/help/help_page.js (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:313: updateEolMessage_:
function(eol_status, message) {
JS uses a different style than C++

eol_status -> eolStatus, here and other places

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:315: this.message_ = message;
Can we introduce new properties to hold the eol_status and message instead? It
is easy to make mistakes with this code and collides with setUpdateStatus_
above.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:321: 
nuke two and keep only one empty line.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_browsertest.js:139: 
nit: nuke

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:219: return
l10n_util::GetStringUTF16(IDS_ABOUT_PAGE_EOL_EOL) + eol_link;
Cancat strings like this is not i18n friendly because translators would have no
way to move the link around. We should make templates and use GetStringFUTF16 to
format it like you did for the link.

https://codereview.chromium.org/2060623002/diff/40001/chrome/chrome_browser_c...
File chrome/chrome_browser_chromeos.gypi (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/chrome_browser_c...
chrome/chrome_browser_chromeos.gypi:174: 'browser/chromeos/eol_notification.h',
align with other files.

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:879: // 2: EOL. Device is End of Life(No more
updates expected).
Also mention it needs to be consistent with EndOfLifeStatus enum

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:880: const char kEolStatus[] = "Eol_status";
Eol_status -> eol_status to be consistent with other prefs.

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:884: const char kEolNotificationDismissed[] =
"Eol_Notification_dismissed";
Eol_Notification_dismissed -> eol_notification_dismissed

[Ilya Sherman, 2016-06-16 23:14:10]

histograms.xml lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-17 04:07:35]

Thank you for your review comment!

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5776: <message
name="IDS_ABOUT_PAGE_EOL_SECURITY_ONLY" desc="The message for eol security
only">
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: The "desc" attribute is what our translators see and probably the only
> context they have. It would be great to put in detailed info in addition to
the
> message text itself so that they know where the message is used and for what
> purpose.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5789: <ph name="BEGIN_LINK_EOL">&lt;a
target="_blank" href="$1"&gt;</ph>  More info<ph
name="END_LINK_EOL">&lt;/a&gt;</ph>
On 2016/06/16 22:41:27, xiyuan wrote:
> Are the two spaces before "More info" on purpose? Why do we need to include it
> as part of the link? If it is intentional, we might consider using &nbsp;
> instead of plain space.

Spaces removed.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5792: More info
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: wrong indent?

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5795: Enable Device End of Lfe notification.
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: Lfe -> Life

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:5801: 
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: get rid of one empty line

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:10: #include
"chrome/browser/chromeos/eol_notification.h"
On 2016/06/16 22:41:27, xiyuan wrote:
> Make this the first include and insert a space after it. Then followed by C
> headers, C++ headers, then chromium headers.
> 
> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:31: #include
"ui/message_center/notification_delegate.h"
On 2016/06/16 22:41:27, xiyuan wrote:
> Clean up the includes and remove the unused ones, e.g. bind.h, bind_helper.h
etc

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:53: Profile* profile_;
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: Profile* const profile_; if it never changes during the lifetime of the
> object.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:96: void EolNotification::Update() {
On 2016/06/16 22:41:27, xiyuan wrote:
> Move this down to match its order in the header file.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:114: void
EolNotification::GetEolStatus() {
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: GetEolStatus -> CheckEolStatus seems more fit what it actually does.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:126: int pre_eol_status =
profile_->GetPrefs()->GetInteger(prefs::kEolStatus);
On 2016/06/16 22:41:27, xiyuan wrote:
> nit: const int

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.h (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:8: #include "base/callback.h"
On 2016/06/16 22:41:28, xiyuan wrote:
> not used?

Removed.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:18: class EolNotification {
On 2016/06/16 22:41:28, xiyuan wrote:
> Brief comment to document the class.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:27: Profile* profile_;
On 2016/06/16 22:41:27, xiyuan wrote:
> Members at the end in a section, after all methods.
> 
> https://google.github.io/styleguide/cppguide.html#Declaration_Order

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:27: Profile* profile_;
On 2016/06/16 22:41:28, xiyuan wrote:
> nit: Profile* const profile_;

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:36: int status_;
On 2016/06/16 22:41:27, xiyuan wrote:
> Move it to last. And initialize it with some value.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.h:39: base::string16 GetEolMessage();
On 2016/06/16 22:41:27, xiyuan wrote:
> #include "base/strings/string16.h"

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:22: #include
"chrome/browser/chromeos/eol_notification.h"
On 2016/06/16 22:41:28, xiyuan wrote:
> Forward clear in line 49 is enough, move the include to cc file.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:29: #include
"chromeos/dbus/update_engine_client.h"
On 2016/06/16 22:41:28, xiyuan wrote:
> Do we need this?

Removed.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:259:
std::unique_ptr<EolNotification> eol_notification_;
On 2016/06/16 22:41:28, xiyuan wrote:
> This does not feel belong here. It is user session/profile specific. Doing it
> like this does not work for multi profile case.
> 
> Think it should be part of UserSessionManager and associated with its profile
> similar to |default_ime_states_|.
> 
> Or better yet, make this a KeyedService so that every profile could have an
> instance of it.

Hi Xiyuan,

Could you elaborate what could go wrong? My observation is In the
UserSessionManger after a profile is prepared it will call
ExistingUserController::OnProfilePrepared() with an associating profile.

And ExistingUserController maintains it's own life cycle and deletes itself when
the user logs in, so every login we will have a new ExistingUserController to
reset the EolNotification with the current profile.

I've tested that have multiple profiles in the chromebook and switch account by
login and logout, so far it looks fine.

Let me know if I've missed anything.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:24: #include
"chrome/browser/chromeos/eol_notification.h"
On 2016/06/16 22:41:28, xiyuan wrote:
> seems not needed.

Removed.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/help/help_page.js (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:313: updateEolMessage_:
function(eol_status, message) {
On 2016/06/16 22:41:28, xiyuan wrote:
> JS uses a different style than C++
> 
> eol_status -> eolStatus, here and other places

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:315: this.message_ = message;
On 2016/06/16 22:41:28, xiyuan wrote:
> Can we introduce new properties to hold the eol_status and message instead? It
> is easy to make mistakes with this code and collides with setUpdateStatus_
> above.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:321: 
On 2016/06/16 22:41:28, xiyuan wrote:
> nuke two and keep only one empty line.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_browsertest.js:139: 
On 2016/06/16 22:41:28, xiyuan wrote:
> nit: nuke

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:219: return
l10n_util::GetStringUTF16(IDS_ABOUT_PAGE_EOL_EOL) + eol_link;
On 2016/06/16 22:41:28, xiyuan wrote:
> Cancat strings like this is not i18n friendly because translators would have
no
> way to move the link around. We should make templates and use GetStringFUTF16
to
> format it like you did for the link.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/chrome_browser_c...
File chrome/chrome_browser_chromeos.gypi (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/chrome_browser_c...
chrome/chrome_browser_chromeos.gypi:174: 'browser/chromeos/eol_notification.h',
On 2016/06/16 22:41:28, xiyuan wrote:
> align with other files.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:879: // 2: EOL. Device is End of Life(No more
updates expected).
On 2016/06/16 22:41:28, xiyuan wrote:
> Also mention it needs to be consistent with EndOfLifeStatus enum

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:880: const char kEolStatus[] = "Eol_status";
On 2016/06/16 22:41:28, xiyuan wrote:
> Eol_status -> eol_status to be consistent with other prefs.

Done.

https://codereview.chromium.org/2060623002/diff/40001/chrome/common/pref_name...
chrome/common/pref_names.cc:884: const char kEolNotificationDismissed[] =
"Eol_Notification_dismissed";
On 2016/06/16 22:41:28, xiyuan wrote:
> Eol_Notification_dismissed -> eol_notification_dismissed

Done.

[xiaoyinh(OOO Sep 11-29), 2016-06-17 04:08:56]

stevenjb@, could you help take a look?
Thanks!

[xiyuan, 2016-06-17 15:21:27]

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.h (right):

https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.h:259:
std::unique_ptr<EolNotification> eol_notification_;
On 2016/06/17 04:07:35, xiaoyinh wrote:
> On 2016/06/16 22:41:28, xiyuan wrote:
> > This does not feel belong here. It is user session/profile specific. Doing
it
> > like this does not work for multi profile case.
> > 
> > Think it should be part of UserSessionManager and associated with its
profile
> > similar to |default_ime_states_|.
> > 
> > Or better yet, make this a KeyedService so that every profile could have an
> > instance of it.
> 
> Hi Xiyuan,
> 
> Could you elaborate what could go wrong? My observation is In the
> UserSessionManger after a profile is prepared it will call
> ExistingUserController::OnProfilePrepared() with an associating profile.
> 
> And ExistingUserController maintains it's own life cycle and deletes itself
when
> the user logs in, so every login we will have a new ExistingUserController to
> reset the EolNotification with the current profile.
> 
> I've tested that have multiple profiles in the chromebook and switch account
by
> login and logout, so far it looks fine.
> 
> Let me know if I've missed anything.
> 

ExistingUserController is part of the login screen (owned by
LoginDisplayHostImpl). It will be gone soon after the login screen is dismissed.
However, EolNotification calls update engine and wait for the eol status, which
is not coupled with the login screen life time. So we have a race here. If login
screen is disposed sooner than update engine's call returns, we will never see
the notification.

[xiaoyinh(OOO Sep 11-29), 2016-06-17 18:50:49]

On 2016/06/17 15:21:27, xiyuan wrote:
>
https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/existing_user_controller.h (right):
> 
>
https://codereview.chromium.org/2060623002/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/existing_user_controller.h:259:
> std::unique_ptr<EolNotification> eol_notification_;
> On 2016/06/17 04:07:35, xiaoyinh wrote:
> > On 2016/06/16 22:41:28, xiyuan wrote:
> > > This does not feel belong here. It is user session/profile specific. Doing
> it
> > > like this does not work for multi profile case.
> > > 
> > > Think it should be part of UserSessionManager and associated with its
> profile
> > > similar to |default_ime_states_|.
> > > 
> > > Or better yet, make this a KeyedService so that every profile could have
an
> > > instance of it.
> > 
> > Hi Xiyuan,
> > 
> > Could you elaborate what could go wrong? My observation is In the
> > UserSessionManger after a profile is prepared it will call
> > ExistingUserController::OnProfilePrepared() with an associating profile.
> > 
> > And ExistingUserController maintains it's own life cycle and deletes itself
> when
> > the user logs in, so every login we will have a new ExistingUserController
to
> > reset the EolNotification with the current profile.
> > 
> > I've tested that have multiple profiles in the chromebook and switch account
> by
> > login and logout, so far it looks fine.
> > 
> > Let me know if I've missed anything.
> > 
> 
> ExistingUserController is part of the login screen (owned by
> LoginDisplayHostImpl). It will be gone soon after the login screen is
dismissed.
> However, EolNotification calls update engine and wait for the eol status,
which
> is not coupled with the login screen life time. So we have a race here. If
login
> screen is disposed sooner than update engine's call returns, we will never see
> the notification.

Moved to UserSessionManager::FinalizePrepareProfile, thank you very much for the
explanation.

[xiyuan, 2016-06-17 20:02:10]

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:22: #include "ui/gfx/image/image.h"
nit: not used. Only need to include this if we actually called method of
gfx::Image.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:87:
EolNotification::~EolNotification() {}
Do we need to notification_ui_manager()->CancelById() here? 

What happens in the following scenario:
1. We need to show Eol notification;
2. User A signs in, notification shows up;
3. User B is added to the session;

Would we see two Eol notifications at the same time after 3?

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/help/help_page.js (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:71: eolstatus_: null,
nit: eolStatus_, JS uses camel case with the first letter always in lower case

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:77: eolmessage_: null,
nit: eolMessage_

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:325: updateEolMessage_:
function(eolstatus, eolmessage) {
nit: eolStatus, eolMessage

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:341: var eolmessage =
this.eolmessage_;
ditto

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:216:
base::ASCIIToUTF16(chrome::kEolNotificationURL));
Think we only need one chrome::kEolNotificationURL since the template only needs
one replacement arg.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:221:
base::ASCIIToUTF16(chrome::kEolNotificationURL));
same here.

https://codereview.chromium.org/2060623002/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:885: const char kEolNotificationDismissed[] =
"eol_Notification_dismissed";
all lower case, i.e. eol_notification_dismissed

[xiaoyinh(OOO Sep 11-29), 2016-06-17 22:36:53]

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:22: #include "ui/gfx/image/image.h"
On 2016/06/17 20:02:09, xiyuan wrote:
> nit: not used. Only need to include this if we actually called method of
> gfx::Image.

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/eol_notification.cc:87:
EolNotification::~EolNotification() {}
On 2016/06/17 20:02:09, xiyuan wrote:
> Do we need to notification_ui_manager()->CancelById() here? 
> 
> What happens in the following scenario:
> 1. We need to show Eol notification;
> 2. User A signs in, notification shows up;
> 3. User B is added to the session;
> 
> Would we see two Eol notifications at the same time after 3?
I added CancelById in the EolNotificationDelegate Destructor to clear up
previous eol notification of the same profile

Right now, I only see one notification shows up.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/help/help_page.js (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:71: eolstatus_: null,
On 2016/06/17 20:02:09, xiyuan wrote:
> nit: eolStatus_, JS uses camel case with the first letter always in lower case

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:77: eolmessage_: null,
On 2016/06/17 20:02:09, xiyuan wrote:
> nit: eolMessage_

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:325: updateEolMessage_:
function(eolstatus, eolmessage) {
On 2016/06/17 20:02:09, xiyuan wrote:
> nit: eolStatus, eolMessage

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/resource...
chrome/browser/resources/help/help_page.js:341: var eolmessage =
this.eolmessage_;
On 2016/06/17 20:02:09, xiyuan wrote:
> ditto

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:216:
base::ASCIIToUTF16(chrome::kEolNotificationURL));
On 2016/06/17 20:02:10, xiyuan wrote:
> Think we only need one chrome::kEolNotificationURL since the template only
needs
> one replacement arg.

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/help/help_handler.cc:221:
base::ASCIIToUTF16(chrome::kEolNotificationURL));
On 2016/06/17 20:02:10, xiyuan wrote:
> same here.

Done.

https://codereview.chromium.org/2060623002/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2060623002/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:885: const char kEolNotificationDismissed[] =
"eol_Notification_dismissed";
On 2016/06/17 20:02:10, xiyuan wrote:
> all lower case, i.e. eol_notification_dismissed

Done.

[xiyuan, 2016-06-17 22:43:11]

LGTM with CancelById comment fixed.

https://codereview.chromium.org/2060623002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:56: id(),
NotificationUIManager::GetProfileID(profile_));
Don't do this in NotificationDelegate's destructor. If we do this, do it in
EolNotification's dtor.

And per our discussion, we probably can just remove this and do nothing since we
keep track a per-profile instance of EolNotification now.

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:00:00]

https://codereview.chromium.org/2060623002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:56: id(),
NotificationUIManager::GetProfileID(profile_));
On 2016/06/17 22:43:11, xiyuan wrote:
> Don't do this in NotificationDelegate's destructor. If we do this, do it in
> EolNotification's dtor.
> 
> And per our discussion, we probably can just remove this and do nothing since
we
> keep track a per-profile instance of EolNotification now.

Removed.

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:18:08]

Description was changed from

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:18:08]

xiaoyinh@chromium.org changed reviewers:
+ hashimoto@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:18:19]

Description was changed from

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:20:42]

stevenjb@, hashimoto@,
Could you help take a look Dbus code? Need owner approval.

[xiaoyinh(OOO Sep 11-29), 2016-06-17 23:26:38]

xiaoyinh@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2016-06-17 23:54:58]

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:98: status_ = status;
does it makes sense to check  status_ != state, or early exit if it's same?

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:122: }
nit: remove {}

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.h (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:1: // Copyright (c) 2016 The Chromium
Authors. All rights reserved.
remove (c)
(it's old style)

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:3: // // found in the LICENSE file.
remove extra //

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:4: //
replace empty "//" with empty new line

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:22: class EolNotification {
final (since your dtor is not virtual)

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session/user_session_manager.cc:1684:
.insert(std::make_pair(profile, std::unique_ptr<EolNotification>(
auto notification = base::WrapUnique(new EolNotification());
iter = handler_.insert(notification).first;

would be easier to read

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session/user_session_manager.cc:1889: return
false;
just

return !profile->GeustSession();

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/help/help_browsertest.js:139: 
remove empty line

[stevenjb, 2016-06-18 00:52:58]

I reviewed chromeos/ only.

For future reference, making just the model change (dbus + user_session_manager
and related changes) first and putting that up as a separate CL while working on
the UI changes will give reviewers more time to review just those changes (and
make it easier on the reviewers).

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/fake_upd...
File chromeos/dbus/fake_update_engine_client.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/fake_upd...
chromeos/dbus/fake_update_engine_client.cc:79: const GetEolStatusCallback&
callback) {}
This should trigger its callback with a fake status. (GetChannel should do the
same). This can be done in a follow up.

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
File chromeos/dbus/update_engine_client.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
chromeos/dbus/update_engine_client.cc:379: callback.Run(status);
We should cast status to the correct enum type (and check bounds) here.

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
File chromeos/dbus/update_engine_client.h (right):

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
chromeos/dbus/update_engine_client.h:138: typedef base::Callback<void(int
status)> GetEolStatusCallback;
It looks like we should be calling this with update_engine::EndOfLifeStatus
instead of int (and do the casting in the GetEolStatus success callback).

[xiaoyinh(OOO Sep 11-29), 2016-06-18 01:08:12]

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:98: status_ = status;
On 2016/06/17 23:54:58, oshima wrote:
> does it makes sense to check  status_ != state, or early exit if it's same?

There are cases that we want to show notification everytime no matter what
previous status is(until the notification is dismissed).
For example when device's EndofLife Status is EOL.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.cc:122: }
On 2016/06/17 23:54:58, oshima wrote:
> nit: remove {}

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/eol_notification.h (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:1: // Copyright (c) 2016 The Chromium
Authors. All rights reserved.
On 2016/06/17 23:54:58, oshima wrote:
> remove (c)
> (it's old style)

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:3: // // found in the LICENSE file.
On 2016/06/17 23:54:58, oshima wrote:
> remove extra //

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:4: //
On 2016/06/17 23:54:58, oshima wrote:
> replace empty "//" with empty new line

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/eol_notification.h:22: class EolNotification {
On 2016/06/17 23:54:58, oshima wrote:
> final (since your dtor is not virtual)

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session/user_session_manager.cc:1684:
.insert(std::make_pair(profile, std::unique_ptr<EolNotification>(
On 2016/06/17 23:54:58, oshima wrote:
> auto notification = base::WrapUnique(new EolNotification());
> iter = handler_.insert(notification).first;
> 
> would be easier to read

Hi, I tried to modify like this, but it didn't compile.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session/user_session_manager.cc:1889: return
false;
On 2016/06/17 23:54:58, oshima wrote:
> just
> 
> return !profile->GeustSession();

Done.

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/help/help_browsertest.js (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/ui/webu...
chrome/browser/ui/webui/help/help_browsertest.js:139: 
On 2016/06/17 23:54:58, oshima wrote:
> remove empty line

Done.

[oshima, 2016-06-18 01:23:25]

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/session/user_session_manager.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session/user_session_manager.cc:1684:
.insert(std::make_pair(profile, std::unique_ptr<EolNotification>(
On 2016/06/18 01:08:12, xiaoyinh wrote:
> On 2016/06/17 23:54:58, oshima wrote:
> > auto notification = base::WrapUnique(new EolNotification());
> > iter = handler_.insert(notification).first;
> > 
> > would be easier to read
> 
> Hi, I tried to modify like this, but it didn't compile.

what was the error? Maybe std::move was missing?

[xiaoyinh(OOO Sep 11-29), 2016-06-18 02:09:39]

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/fake_upd...
File chromeos/dbus/fake_update_engine_client.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/fake_upd...
chromeos/dbus/fake_update_engine_client.cc:79: const GetEolStatusCallback&
callback) {}
On 2016/06/18 00:52:58, stevenjb wrote:
> This should trigger its callback with a fake status. (GetChannel should do the
> same). This can be done in a follow up.

Will do it in next CL. Thanks!

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
File chromeos/dbus/update_engine_client.cc (right):

https://codereview.chromium.org/2060623002/diff/140001/chromeos/dbus/update_e...
chromeos/dbus/update_engine_client.cc:379: callback.Run(status);
On 2016/06/18 00:52:58, stevenjb wrote:
> We should cast status to the correct enum type (and check bounds) here.

Added validation Check.
Steven, mind if I change the type in a follow-up. Just tried to change type and
it could impact multiple files so I'm thinking if possible to do it in next CL?
Let me know. 

Thanks!

[xiaoyinh(OOO Sep 11-29), 2016-06-18 02:10:15]

On 2016/06/18 01:23:25, oshima wrote:
>
https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/session/user_session_manager.cc (right):
> 
>
https://codereview.chromium.org/2060623002/diff/140001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/session/user_session_manager.cc:1684:
> .insert(std::make_pair(profile, std::unique_ptr<EolNotification>(
> On 2016/06/18 01:08:12, xiaoyinh wrote:
> > On 2016/06/17 23:54:58, oshima wrote:
> > > auto notification = base::WrapUnique(new EolNotification());
> > > iter = handler_.insert(notification).first;
> > > 
> > > would be easier to read
> > 
> > Hi, I tried to modify like this, but it didn't compile.
> 
> what was the error? Maybe std::move was missing?

Thank you for the suggestion.
Changed.

[oshima, 2016-06-18 03:31:51]

lgtm

[xiaoyinh(OOO Sep 11-29), 2016-06-18 03:44:55]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-18 03:45:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060623002/200001

[commit-bot: I haz the power, 2016-06-18 04:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 04:09:28]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2016-06-18 04:46:01]

The CQ bit was checked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2016-06-18 04:46:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2060623002/#ps200001
(title: "fix the browser test and rebase branch")

[commit-bot: I haz the power, 2016-06-18 04:46:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060623002/200001

[commit-bot: I haz the power, 2016-06-18 04:50:36]

Description was changed from

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-18 04:50:38]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-18 04:52:25]

Description was changed from

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG=611816
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec
Cr-Commit-Position: refs/heads/master@{#400578}
==========

[commit-bot: I haz the power, 2016-06-18 04:52:26]

Patchset 11 (id:??) landed as
https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec
Cr-Commit-Position: refs/heads/master@{#400578}