Implementation of Device End of Life Notification

chrome/browser/chromeos/eol_notification.cc

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// // Use of this source code is governed by a BSD-style license that can be
+// // found in the LICENSE file.
+
+#include "ash/system/system_notifier.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/eol_notification.h"

[xiyuan, 2016/06/16 22:41:27]

Make this the first include and insert a space after it. Then followed by C
headers, C++ headers, then chromium headers.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+#include "chrome/browser/notifications/notification.h"
+#include "chrome/browser/notifications/notification_delegate.h"
+#include "chrome/browser/notifications/notification_ui_manager.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/browser_navigator.h"
+#include "chrome/browser/ui/browser_navigator_params.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/grit/generated_resources.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/update_engine_client.h"
+#include "components/prefs/pref_service.h"
+#include "grit/ash_resources.h"
+#include "third_party/cros_system_api/dbus/update_engine/dbus-constants.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/image/image.h"
+#include "ui/message_center/message_center.h"
+#include "ui/message_center/notification.h"
+#include "ui/message_center/notification_delegate.h"

[xiyuan, 2016/06/16 22:41:27]

Clean up the includes and remove the unused ones, e.g. bind.h, bind_helper.h etc

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+
+using message_center::MessageCenter;
+
+namespace chromeos {
+namespace {
+
+const char kEolNotificationId[] = "eol";
+const char kDelegateId[] = "eol_delegate";
+
+class EolNotificationDelegate : public NotificationDelegate {
+ public:
+  explicit EolNotificationDelegate(Profile* profile);
+
+ private:
+  ~EolNotificationDelegate() override;
+
+  // NotificationDelegate overrides:
+  void Close(bool by_user) override;
+  void ButtonClick(int button_index) override;
+  std::string id() const override;
+
+  Profile* profile_;

[xiyuan, 2016/06/16 22:41:27]

nit: Profile* const profile_; if it never changes during the lifetime of the
object.

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+
+  void OpenMoreInfoPage();
+
+  DISALLOW_COPY_AND_ASSIGN(EolNotificationDelegate);
+};
+
+EolNotificationDelegate::EolNotificationDelegate(Profile* profile)
+    : profile_(profile) {}
+
+EolNotificationDelegate::~EolNotificationDelegate() {}
+
+void EolNotificationDelegate::Close(bool by_user) {
+  if (by_user) {
+    // set dismiss pref.
+    profile_->GetPrefs()->SetBoolean(prefs::kEolNotificationDismissed, true);
+  }
+}
+
+void EolNotificationDelegate::ButtonClick(int button_index) {
+  // show eol link
+  OpenMoreInfoPage();
+}
+
+std::string EolNotificationDelegate::id() const {
+  return kDelegateId;
+}
+
+void EolNotificationDelegate::OpenMoreInfoPage() {
+  chrome::NavigateParams params(profile_, GURL(chrome::kEolNotificationURL),
+                                ui::PAGE_TRANSITION_LINK);
+  params.disposition = NEW_FOREGROUND_TAB;
+  params.window_action = chrome::NavigateParams::SHOW_WINDOW;
+  chrome::Navigate(&params);
+}
+
+}  // namespace
+
+EolNotification::EolNotification(Profile* profile)
+    : profile_(profile), weak_factory_(this) {}
+
+EolNotification::~EolNotification() {}
+
+void EolNotification::Update() {

[xiyuan, 2016/06/16 22:41:27]

Move this down to match its order in the header file.

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+  ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
+  message_center::RichNotificationData data;
+  data.buttons.push_back(message_center::ButtonInfo(
+      l10n_util::GetStringUTF16(IDS_EOL_MORE_INFO_BUTTON)));
+
+  Notification notification(
+      message_center::NOTIFICATION_TYPE_SIMPLE,
+      base::string16(),  // title
+      // TODO(xiaoyinh): Update the Eol icon once it's ready.
+      GetEolMessage(), bundle.GetImageNamed(IDR_AURA_NOTIFICATION_DISPLAY),
+      message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
+                                 kEolNotificationId),
+      base::string16(),  // display_source
+      GURL(), kEolNotificationId, data, new EolNotificationDelegate(profile_));
+  g_browser_process->notification_ui_manager()->Add(notification, profile_);
+}
+
+void EolNotification::GetEolStatus() {

[xiyuan, 2016/06/16 22:41:27]

nit: GetEolStatus -> CheckEolStatus seems more fit what it actually does.

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+  UpdateEngineClient* update_engine_client =
+      DBusThreadManager::Get()->GetUpdateEngineClient();
+
+  // Request the Eol Status.
+  update_engine_client->GetEolStatus(
+      base::Bind(&EolNotification::OnEolStatus, weak_factory_.GetWeakPtr()));
+}
+
+void EolNotification::OnEolStatus(int status) {
+  status_ = status;
+
+  int pre_eol_status = profile_->GetPrefs()->GetInteger(prefs::kEolStatus);

[xiyuan, 2016/06/16 22:41:27]

nit: const int

[xiaoyinh(OOO Sep 11-29), 2016/06/17 04:07:34]

Done.

+
+  profile_->GetPrefs()->SetInteger(prefs::kEolStatus, status_);
+
+  if (status_ == update_engine::EndOfLifeStatus::kSupported)
+    return;
+
+  if (pre_eol_status != status_) {
+    // If Eol status has changed, we should reset
+    // kEolNotificationDismissed and show notification.
+    profile_->GetPrefs()->SetBoolean(prefs::kEolNotificationDismissed, false);
+  }
+
+  bool user_dismissed_eol_notification =
+      profile_->GetPrefs()->GetBoolean(prefs::kEolNotificationDismissed);
+
+  if (user_dismissed_eol_notification)
+    return;
+
+  // When device is in Security-Only state, only show notification the first
+  // time.
+  if (status_ == update_engine::EndOfLifeStatus::kSecurityOnly) {
+    profile_->GetPrefs()->SetBoolean(prefs::kEolNotificationDismissed, true);
+  }
+
+  Update();
+}
+
+base::string16 EolNotification::GetEolMessage() {
+  if (status_ == update_engine::EndOfLifeStatus::kSecurityOnly) {
+    return l10n_util::GetStringUTF16(IDS_EOL_NOTIFICATION_SECURITY_ONLY);
+  } else {
+    return l10n_util::GetStringUTF16(IDS_EOL_NOTIFICATION_EOL);
+  }
+}
+
+}  // namespace chromeos