Implementation of Device End of Life Notification

chromeos/dbus/update_engine_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/update_engine_client.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 
@@ skipping 189 matching lines @@
     VLOG(1) << "Requesting to get channel, get_current_channel="
             << get_current_channel;
     update_engine_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&UpdateEngineClientImpl::OnGetChannel,
                    weak_ptr_factory_.GetWeakPtr(),
                    callback));
   }
 
+  void GetEolStatus(const GetEolStatusCallback& callback) override {
+    dbus::MethodCall method_call(update_engine::kUpdateEngineInterface,
+                                 update_engine::kGetEolStatus);
+
+    VLOG(1) << "Requesting to get end of life status";
+    update_engine_proxy_->CallMethod(
+        &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+        base::Bind(&UpdateEngineClientImpl::OnGetEolStatus,
+                   weak_ptr_factory_.GetWeakPtr(), callback));
+  }
+
  protected:
   void Init(dbus::Bus* bus) override {
     update_engine_proxy_ = bus->GetObjectProxy(
         update_engine::kUpdateEngineServiceName,
         dbus::ObjectPath(update_engine::kUpdateEngineServicePath));
 
     // Monitor the D-Bus signal for brightness changes. Only the power
     // manager knows the actual brightness level. We don't cache the
     // brightness level in Chrome as it will make things less reliable.
     update_engine_proxy_->ConnectToSignal(
@@ skipping 122 matching lines @@
     std::string channel;
     if (!reader.PopString(&channel)) {
       LOG(ERROR) << "Incorrect response: " << response->ToString();
       callback.Run("");
       return;
     }
     VLOG(1) << "The channel received: " << channel;
     callback.Run(channel);
   }
 
+  // Called when a response for GetEolStatus() is received.
+  void OnGetEolStatus(const GetEolStatusCallback& callback,
+                      dbus::Response* response) {
+    if (!response) {
+      LOG(ERROR) << "Failed to request getting eol status";
+      callback.Run(update_engine::EndOfLifeStatus::kSupported);
+      return;
+    }
+    dbus::MessageReader reader(response);
+    int status;
+    if (!reader.PopInt32(&status)) {
+      LOG(ERROR) << "Incorrect response: " << response->ToString();
+      callback.Run(update_engine::EndOfLifeStatus::kSupported);
+      return;
+    }
+    VLOG(1) << "Eol status received: " << status;
+    callback.Run(status);

[stevenjb, 2016/06/18 00:52:58]

We should cast status to the correct enum type (and check bounds) here.

[xiaoyinh(OOO Sep 11-29), 2016/06/18 02:09:39]

Added validation Check.
Steven, mind if I change the type in a follow-up. Just tried to change type and
it could impact multiple files so I'm thinking if possible to do it in next CL?
Let me know. 

Thanks!

+  }
+
   // Called when a status update signal is received.
   void StatusUpdateReceived(dbus::Signal* signal) {
     VLOG(1) << "Status update signal received: " << signal->ToString();
     dbus::MessageReader reader(signal);
     int64_t last_checked_time = 0;
     double progress = 0.0;
     std::string current_operation;
     std::string new_version;
     int64_t new_size = 0;
     if (!(reader.PopInt64(&last_checked_time) &&
@@ skipping 68 matching lines @@
   void GetChannel(bool get_current_channel,
                   const GetChannelCallback& callback) override {
     VLOG(1) << "Requesting to get channel, get_current_channel="
             << get_current_channel;
     if (get_current_channel)
       callback.Run(current_channel_);
     else
       callback.Run(target_channel_);
   }
 
+  void GetEolStatus(const GetEolStatusCallback& callback) override {
+    callback.Run(update_engine::EndOfLifeStatus::kSupported);
+  }
+
   std::string current_channel_;
   std::string target_channel_;
 };
 
 // The UpdateEngineClient implementation used on Linux desktop, which
 // tries to emulate real update engine client.
 class UpdateEngineClientFakeImpl : public UpdateEngineClientStubImpl {
  public:
   UpdateEngineClientFakeImpl() : weak_factory_(this) {
   }
@@ skipping 117 matching lines @@
   auto cix = std::find(kReleaseChannelsList,
                        kReleaseChannelsList + arraysize(kReleaseChannelsList),
                        current_channel);
   auto tix = std::find(kReleaseChannelsList,
                        kReleaseChannelsList + arraysize(kReleaseChannelsList),
                        target_channel);
   return tix > cix;
 }
 
 }  // namespace chromeos