service worker: Fix the type of a register promise reject value

service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
Committed: https://crrev.com/0f261ebcb6c9cc48e98f736a0253fa9aa336a898
Cr-Commit-Position: refs/heads/master@{#404388}

[e_hakkinen, 2016-06-10 20:32:15]

Patchset #1 (id:1) has been deleted

[e_hakkinen, 2016-06-10 20:39:43]

Description was changed from

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
==========

to

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
==========

[e_hakkinen, 2016-06-10 20:39:43]

eero.hakkinen@intel.com changed reviewers:
+ horo@chromium.org, shimazu@chromium.org

[falken, 2016-06-14 02:29:18]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2016-06-14 02:29:18]

https://codereview.chromium.org/2059953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
(right):

https://codereview.chromium.org/2059953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp:86:
break;
Why are these types the ones in the switch?

This is also the same code as in the update patch. It'd be better if it's in one
place.

[e_hakkinen, 2016-07-08 12:21:13]

https://codereview.chromium.org/2059953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
(right):

https://codereview.chromium.org/2059953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp:86:
break;
On 2016/06/14 02:29:18, falken wrote:
> Why are these types the ones in the switch?
> 
> This is also the same code as in the update patch. It'd be better if it's in
one
> place.

Done.

[falken, 2016-07-08 12:39:46]

great, lgtm

https://codereview.chromium.org/2059953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
(right):

https://codereview.chromium.org/2059953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp:84:
m_resolver->reject(ServiceWorkerErrorForRegister::take(m_resolver.get(),
error));
optional nit: mm.. I'd just save a line of code and use
ServiceWorkerErrorForUpdate directly, update and register are understood to be
interrelated.

[e_hakkinen, 2016-07-08 12:48:51]

https://codereview.chromium.org/2059953003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
(right):

https://codereview.chromium.org/2059953003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp:84:
m_resolver->reject(ServiceWorkerErrorForRegister::take(m_resolver.get(),
error));
On 2016/07/08 12:39:46, falken wrote:
> optional nit: mm.. I'd just save a line of code and use
> ServiceWorkerErrorForUpdate directly, update and register are understood to be
> interrelated.

Done.

[e_hakkinen, 2016-07-08 12:49:17]

The CQ bit was checked by eero.hakkinen@intel.com

[e_hakkinen, 2016-07-08 12:49:17]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2059953003/#ps60001
(title: "Use ServiceWorkerErrorForUpdate directly")

[commit-bot: I haz the power, 2016-07-08 12:49:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 14:52:48]

Description was changed from

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
==========

to

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
==========

[commit-bot: I haz the power, 2016-07-08 14:52:49]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-08 14:54:24]

Description was changed from

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881
==========

to

==========
service worker: Fix the type of a register promise reject value

This CL changes the type of the register promise reject value to be
TypeError (instead of AbortError or NetworkError) if the register promise
is rejected because an uncaught runtime script error occured during Run
Service Worker algorithm.

BUG=617881

Committed: https://crrev.com/0f261ebcb6c9cc48e98f736a0253fa9aa336a898
Cr-Commit-Position: refs/heads/master@{#404388}
==========

[commit-bot: I haz the power, 2016-07-08 14:54:25]

Patchset 3 (id:??) landed as
https://crrev.com/0f261ebcb6c9cc48e98f736a0253fa9aa336a898
Cr-Commit-Position: refs/heads/master@{#404388}