service worker: Fix the type of a register promise reject value

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 58 matching lines @@
     {
         if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())
             return;
         m_resolver->resolve(ServiceWorkerRegistration::getOrCreate(m_resolver->getExecutionContext(), adoptPtr(handle.release())));
     }
 
     void onError(const WebServiceWorkerError& error) override
     {
         if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())
             return;
-        if (error.errorType == WebServiceWorkerError::ErrorTypeType) {
-            m_resolver->reject(V8ThrowException::createTypeError(m_resolver->getScriptState()->isolate(), error.message));
-        } else {
+        switch (error.errorType) {
+        case WebServiceWorkerError::ErrorTypeNetwork:
+        case WebServiceWorkerError::ErrorTypeScriptEvaluateFailed:
+        case WebServiceWorkerError::ErrorTypeType: {
+            ScriptState* scriptState = m_resolver->getScriptState();
+            ScriptState::Scope scope(scriptState);
+            m_resolver->reject(V8ThrowException::createTypeError(scriptState->isolate(), error.message));
+            break;

[falken, 2016/06/14 02:29:18]

Why are these types the ones in the switch?

This is also the same code as in the update patch. It'd be better if it's in one
place.

[e_hakkinen, 2016/07/08 12:21:13]

Done.

+        }
+        default:
             m_resolver->reject(ServiceWorkerError::take(m_resolver.get(), error));
         }
     }
 
 private:
     Persistent<ScriptPromiseResolver> m_resolver;
     WTF_MAKE_NONCOPYABLE(RegistrationCallback);
 };
 
 class GetRegistrationCallback : public WebServiceWorkerProvider::WebServiceWorkerGetRegistrationCallbacks {
@@ skipping 325 matching lines @@
         return;
 
     if (ServiceWorkerContainerClient* client = ServiceWorkerContainerClient::from(executionContext)) {
         m_provider = client->provider();
         if (m_provider)
             m_provider->setClient(this);
     }
 }
 
 } // namespace blink