Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html

Issue 2059953003: service worker: Fix the type of a register promise reject value (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Use ServiceWorkerErrorForUpdate directly Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/registration-tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html
index 3f1684f0c254aa6480ad11b6717cf815977a7f3c..beba595cd0d4201c169c78bbaa65d73eb8fc1b47 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html
@@ -47,7 +47,7 @@ async_test(function(t) {
'- normal case');
// Set script url and scope url relative to the iframe's document's url.
-// Assert the implementation throws a NetworkError exception.
+// Assert the implementation throws a TypeError exception.
async_test(function(t) {
var url = 'resources/blank.html';
var scope = 'registration-for-iframe-from-calling-frame';
@@ -68,7 +68,7 @@ async_test(function(t) {
assert_unreached('register() should reject');
},
function(e) {
- assert_equals(e.name, 'NetworkError');
+ assert_equals(e.name, 'TypeError');
frame.remove();
return service_worker_unregister_and_done(t, scope);
})
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/registration-tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698