Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Issue 2059763002: Update dart2js deps to prevent crash on unsupported platform libraries. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@mandatory_initializer
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Update dart2js deps to prevent crash on unsupported platform libraries. Fixes #13. BUG=https://github.com/dart-lang/rasta/issues/13 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/1d824504fd534ef7b57af4dfbfb2e35771b1fd56

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M lib/src/run_batch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M submodules.txt View 1 chunk +1 line, -1 line 0 comments Download
A + test/kernel/regression/unsupported_platform_library.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A test/kernel/regression/unsupported_platform_library.dart.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (6 generated)
ahe
4 years, 6 months ago (2016-06-10 14:51:48 UTC) #3
kasperl
LGTM.
4 years, 6 months ago (2016-06-13 06:38:13 UTC) #7
ahe
4 years, 6 months ago (2016-06-15 10:09:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:50007) manually as
1d824504fd534ef7b57af4dfbfb2e35771b1fd56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698