Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2055213002: Fix crash on mandatory parameters with initializers. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@for_in
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Fix crash on mandatory parameters with initializers. Fixes #23. BUG=https://github.com/dart-lang/rasta/issues/23 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/d174534e07e644a039de36f3cfa7558766bab396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M lib/kernel_visitor.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + test/kernel/regression/mandatory_parameter_initializer.dart View 1 chunk +1 line, -2 lines 0 comments Download
A test/kernel/regression/mandatory_parameter_initializer.dart.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
4 years, 6 months ago (2016-06-10 12:45:59 UTC) #2
kasperl
LGTM.
4 years, 6 months ago (2016-06-13 06:37:40 UTC) #3
ahe
4 years, 6 months ago (2016-06-15 10:06:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d174534e07e644a039de36f3cfa7558766bab396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698