Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2058023003: Update dart2js to handle parse error in constructor. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@library_import_chain
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Update dart2js to handle parse error in constructor. Fixes #24. BUG=https://github.com/dart-lang/rasta/issues/24 R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/a6becbe49d8bdbeb63699454eaa15ed0ab329093

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M submodules.txt View 1 chunk +1 line, -1 line 0 comments Download
A test/kernel/regression/type_with_parse_error.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A + test/kernel/regression/type_with_parse_error.dart.txt View 1 chunk +6 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
4 years, 6 months ago (2016-06-10 15:43:44 UTC) #3
kasperl
LGTM.
4 years, 6 months ago (2016-06-13 06:38:55 UTC) #4
ahe
4 years, 6 months ago (2016-06-15 10:12:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a6becbe49d8bdbeb63699454eaa15ed0ab329093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698