extensions/shell/browser/shell_app_delegate.h - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_app_delegate.h

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_app_delegate.h

diff --git a/extensions/shell/browser/shell_app_delegate.h b/extensions/shell/browser/shell_app_delegate.h

index 22b3ec014387bcf3858797faa3a58c176d0772d5..599ebe93ab6a325b47cda2e1189698dc56a0d997 100644

--- a/extensions/shell/browser/shell_app_delegate.h

+++ b/extensions/shell/browser/shell_app_delegate.h

@@ -35,7 +35,7 @@ class ShellAppDelegate : public AppDelegate {

bool* was_blocked) override;

content::ColorChooser* ShowColorChooser(content::WebContents* web_contents,

SkColor initial_color) override;

- void RunFileChooser(content::WebContents* tab,

+ void RunFileChooser(content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) override;

void RequestMediaAccessPermission(

content::WebContents* web_contents,

« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/shell/browser/shell_app_delegate.cc » ('j') | no next file with comments »