apps/custom_launcher_page_contents.cc - Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/custom_launcher_page_contents.cc

Issue 2059533002: Change WebContentsDelegate::RunFileChooser to be frame based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/custom_launcher_page_contents.cc

diff --git a/apps/custom_launcher_page_contents.cc b/apps/custom_launcher_page_contents.cc

index 0f41300dd99e5b325fd07c7b8deda1a98ae43a8e..41013626df9ab7aae6b7c2c72cb280f583b823bc 100644

--- a/apps/custom_launcher_page_contents.cc

+++ b/apps/custom_launcher_page_contents.cc

@@ -102,9 +102,9 @@ content::ColorChooser* CustomLauncherPageContents::OpenColorChooser(

}

void CustomLauncherPageContents::RunFileChooser(

- content::WebContents* tab,

+ content::RenderFrameHost* render_frame_host,

const content::FileChooserParams& params) {

- app_delegate_->RunFileChooser(tab, params);

+ app_delegate_->RunFileChooser(render_frame_host, params);

}

void CustomLauncherPageContents::RequestToLockMouse(

« no previous file with comments | « apps/custom_launcher_page_contents.h ('k') | chrome/browser/android/tab_web_contents_delegate_android.h » ('j') | no next file with comments »