Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2058433002: In DevicePermissionsViewController disable Connect button if no device selected on Mac (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In DevicePermissionsViewController disable Connect button if no device selected on Mac When no device selected in the dialog, the "Connect" button needs to be disabled. BUG=613596 Committed: https://crrev.com/6bd72b6044eb4d50ddae075d15f36f286a89232f Cr-Commit-Position: refs/heads/master@{#398958}

Patch Set 1 : in DevicePermissionsViewController disable Connect button if no device selected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
juncai
Please take a look.
4 years, 6 months ago (2016-06-09 17:37:11 UTC) #2
Robert Sesek
LGTM once you remove the duplicate line in the CL description
4 years, 6 months ago (2016-06-09 17:40:09 UTC) #3
juncai
On 2016/06/09 17:40:09, Robert Sesek wrote: > LGTM once you remove the duplicate line in ...
4 years, 6 months ago (2016-06-09 17:59:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058433002/1
4 years, 6 months ago (2016-06-09 17:59:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 18:41:01 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 18:41:18 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 18:46:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bd72b6044eb4d50ddae075d15f36f286a89232f
Cr-Commit-Position: refs/heads/master@{#398958}

Powered by Google App Engine
This is Rietveld 408576698