Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

Issue 2058433002: In DevicePermissionsViewController disable Connect button if no device selected on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: in DevicePermissionsViewController disable Connect button if no device selected Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "base/mac/bundle_locations.h" 5 #import "base/mac/bundle_locations.h"
6 #include "base/strings/sys_string_conversions.h" 6 #include "base/strings/sys_string_conversions.h"
7 #import "chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller .h" 7 #import "chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller .h"
8 #import "chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.h " 8 #import "chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.h "
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "grit/components_strings.h" 10 #include "grit/components_strings.h"
(...skipping 28 matching lines...) Expand all
39 39
40 - (void)devicesChanged { 40 - (void)devicesChanged {
41 [tableView_ reloadData]; 41 [tableView_ reloadData];
42 } 42 }
43 43
44 - (void)awakeFromNib { 44 - (void)awakeFromNib {
45 [titleField_ setStringValue:base::SysUTF16ToNSString(prompt_->GetHeading())]; 45 [titleField_ setStringValue:base::SysUTF16ToNSString(prompt_->GetHeading())];
46 [promptField_ 46 [promptField_
47 setStringValue:base::SysUTF16ToNSString(prompt_->GetPromptMessage())]; 47 setStringValue:base::SysUTF16ToNSString(prompt_->GetPromptMessage())];
48 [tableView_ setAllowsMultipleSelection:prompt_->multiple()]; 48 [tableView_ setAllowsMultipleSelection:prompt_->multiple()];
49 [tableView_ setDelegate:self];
50 [tableView_ setDataSource:self];
49 [[deviceNameColumn_ headerCell] 51 [[deviceNameColumn_ headerCell]
50 setStringValue:l10n_util::GetNSString( 52 setStringValue:l10n_util::GetNSString(
51 IDS_DEVICE_PERMISSIONS_DIALOG_DEVICE_NAME_COLUMN)]; 53 IDS_DEVICE_PERMISSIONS_DIALOG_DEVICE_NAME_COLUMN)];
52 [[serialNumberColumn_ headerCell] 54 [[serialNumberColumn_ headerCell]
53 setStringValue:l10n_util::GetNSString( 55 setStringValue:l10n_util::GetNSString(
54 IDS_DEVICE_PERMISSIONS_DIALOG_SERIAL_NUMBER_COLUMN)]; 56 IDS_DEVICE_PERMISSIONS_DIALOG_SERIAL_NUMBER_COLUMN)];
55 [okButton_ 57 [okButton_
56 setTitle:l10n_util::GetNSString(IDS_DEVICE_PERMISSIONS_DIALOG_SELECT)]; 58 setTitle:l10n_util::GetNSString(IDS_DEVICE_PERMISSIONS_DIALOG_SELECT)];
59 [okButton_ setEnabled:NO];
57 [cancelButton_ setTitle:l10n_util::GetNSString(IDS_CANCEL)]; 60 [cancelButton_ setTitle:l10n_util::GetNSString(IDS_CANCEL)];
58 } 61 }
59 62
60 - (NSInteger)numberOfRowsInTableView:(NSTableView*)tableView { 63 - (NSInteger)numberOfRowsInTableView:(NSTableView*)tableView {
61 DCHECK_EQ(tableView_, tableView); 64 DCHECK_EQ(tableView_, tableView);
62 return prompt_->GetDeviceCount(); 65 return prompt_->GetDeviceCount();
63 } 66 }
64 67
65 - (id)tableView:(NSTableView*)tableView 68 - (id)tableView:(NSTableView*)tableView
66 objectValueForTableColumn:(NSTableColumn*)tableColumn 69 objectValueForTableColumn:(NSTableColumn*)tableColumn
67 row:(NSInteger)rowIndex { 70 row:(NSInteger)rowIndex {
68 if (tableColumn == deviceNameColumn_) { 71 if (tableColumn == deviceNameColumn_) {
69 return base::SysUTF16ToNSString(prompt_->GetDeviceName(rowIndex)); 72 return base::SysUTF16ToNSString(prompt_->GetDeviceName(rowIndex));
70 } else if (tableColumn == serialNumberColumn_) { 73 } else if (tableColumn == serialNumberColumn_) {
71 return base::SysUTF16ToNSString(prompt_->GetDeviceSerialNumber(rowIndex)); 74 return base::SysUTF16ToNSString(prompt_->GetDeviceSerialNumber(rowIndex));
72 } else { 75 } else {
73 NOTREACHED(); 76 NOTREACHED();
74 return @""; 77 return @"";
75 } 78 }
76 } 79 }
77 80
81 - (void)tableViewSelectionDidChange:(NSNotification*)aNotification {
82 [okButton_ setEnabled:[tableView_ numberOfSelectedRows] > 0];
83 }
84
78 @end 85 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698