Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2955)

Unified Diff: chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm

Issue 2058433002: In DevicePermissionsViewController disable Connect button if no device selected on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: in DevicePermissionsViewController disable Connect button if no device selected Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm b/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm
index bcade03655893262b556b164ebdc2cbb0df111eb..bcd4502d096ee91324d7f8e0dabd3da656ffbba5 100644
--- a/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/device_permissions_view_controller.mm
@@ -46,6 +46,8 @@ using extensions::DevicePermissionsPrompt;
[promptField_
setStringValue:base::SysUTF16ToNSString(prompt_->GetPromptMessage())];
[tableView_ setAllowsMultipleSelection:prompt_->multiple()];
+ [tableView_ setDelegate:self];
+ [tableView_ setDataSource:self];
[[deviceNameColumn_ headerCell]
setStringValue:l10n_util::GetNSString(
IDS_DEVICE_PERMISSIONS_DIALOG_DEVICE_NAME_COLUMN)];
@@ -54,6 +56,7 @@ using extensions::DevicePermissionsPrompt;
IDS_DEVICE_PERMISSIONS_DIALOG_SERIAL_NUMBER_COLUMN)];
[okButton_
setTitle:l10n_util::GetNSString(IDS_DEVICE_PERMISSIONS_DIALOG_SELECT)];
+ [okButton_ setEnabled:NO];
[cancelButton_ setTitle:l10n_util::GetNSString(IDS_CANCEL)];
}
@@ -75,4 +78,8 @@ using extensions::DevicePermissionsPrompt;
}
}
+- (void)tableViewSelectionDidChange:(NSNotification*)aNotification {
+ [okButton_ setEnabled:[tableView_ numberOfSelectedRows] > 0];
+}
+
@end
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698