Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 205843002: GPU: Only restore one texture unit in ScopedTextureBinder. (Closed)

Created:
6 years, 9 months ago by epenner
Modified:
6 years, 9 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GPU: Only restore one texture unit in ScopedTextureBinder. We only set one, so only one needs to be restored. Restoring all can really add up with multiple targets and potentially hundreds of units. BUG=353879, 353822 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258678

Patch Set 1 : #

Patch Set 2 : Fix Mock. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M gpu/command_buffer/service/context_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_state_restorer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_state_restorer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_state_restorer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/scoped_binders.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
epenner
Whipped this up as I think it's important shortly. Thankfully the ScopedTextureBinder doesn't require several ...
6 years, 9 months ago (2014-03-20 01:17:02 UTC) #1
epenner
On 2014/03/20 01:17:02, epenner wrote: > Whipped this up as I think it's important shortly. ...
6 years, 9 months ago (2014-03-20 01:20:39 UTC) #2
piman
lgtm
6 years, 9 months ago (2014-03-20 21:08:17 UTC) #3
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-20 21:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/205843002/60001
6 years, 9 months ago (2014-03-20 21:57:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 00:50:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=285636
6 years, 9 months ago (2014-03-21 00:50:50 UTC) #7
epenner
The CQ bit was checked by epenner@chromium.org
6 years, 9 months ago (2014-03-21 20:57:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/205843002/60001
6 years, 9 months ago (2014-03-21 20:57:48 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 22:05:33 UTC) #10
Message was sent while issue was closed.
Change committed as 258678

Powered by Google App Engine
This is Rietveld 408576698