Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: blimp/client/core/contents/BUILD.gn

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: More kmarshall comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/BUILD.gn
diff --git a/blimp/client/core/contents/BUILD.gn b/blimp/client/core/contents/BUILD.gn
index 33a5b40286d99a624cea7cbccb04ca832d5b4e2c..9bd31bca69c657aeb0b2a927f7786b00d2c64125 100644
--- a/blimp/client/core/contents/BUILD.gn
+++ b/blimp/client/core/contents/BUILD.gn
@@ -16,11 +16,14 @@ source_set("contents") {
"blimp_navigation_controller_delegate.h",
"blimp_navigation_controller_impl.cc",
"blimp_navigation_controller_impl.h",
+ "navigation_feature.cc",
+ "navigation_feature.h",
]
public_deps = [
"//base",
"//blimp/client/public:public_headers",
+ "//blimp/common/proto",
"//url",
]
@@ -44,6 +47,26 @@ source_set("contents") {
}
}
+source_set("test_support") {
+ testonly = true
+
+ sources = [
+ "fake_navigation_feature.cc",
+ "fake_navigation_feature.h",
+ "mock_navigation_feature_delegate.cc",
+ "mock_navigation_feature_delegate.h",
+ ]
+
+ deps = [
+ "//skia",
+ "//url",
+ ]
+
+ public_deps = [
+ "//testing/gmock",
+ ]
+}
+
source_set("unit_tests") {
visibility = [ "//blimp/client/core:unit_tests" ]
@@ -52,10 +75,12 @@ source_set("unit_tests") {
sources = [
"blimp_contents_impl_unittest.cc",
"blimp_navigation_controller_impl_unittest.cc",
+ "navigation_feature_unittest.cc",
]
deps = [
":contents",
+ ":test_support",
"//base",
"//blimp/client/public:public_headers",
"//testing/gtest",

Powered by Google App Engine
This is Rietveld 408576698