Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: blimp/client/core/contents/BUILD.gn

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: More kmarshall comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 source_set("contents") { 10 source_set("contents") {
11 visibility = [ "//blimp/client/*" ] 11 visibility = [ "//blimp/client/*" ]
12 12
13 sources = [ 13 sources = [
14 "blimp_contents_impl.cc", 14 "blimp_contents_impl.cc",
15 "blimp_contents_impl.h", 15 "blimp_contents_impl.h",
16 "blimp_navigation_controller_delegate.h", 16 "blimp_navigation_controller_delegate.h",
17 "blimp_navigation_controller_impl.cc", 17 "blimp_navigation_controller_impl.cc",
18 "blimp_navigation_controller_impl.h", 18 "blimp_navigation_controller_impl.h",
19 "navigation_feature.cc",
20 "navigation_feature.h",
19 ] 21 ]
20 22
21 public_deps = [ 23 public_deps = [
22 "//base", 24 "//base",
23 "//blimp/client/public:public_headers", 25 "//blimp/client/public:public_headers",
26 "//blimp/common/proto",
24 "//url", 27 "//url",
25 ] 28 ]
26 29
27 if (is_android) { 30 if (is_android) {
28 sources += [ 31 sources += [
29 "android/blimp_contents_factory.cc", 32 "android/blimp_contents_factory.cc",
30 "android/blimp_contents_factory.h", 33 "android/blimp_contents_factory.h",
31 "android/blimp_contents_impl_android.cc", 34 "android/blimp_contents_impl_android.cc",
32 "android/blimp_contents_impl_android.h", 35 "android/blimp_contents_impl_android.h",
33 "android/blimp_contents_jni_registrar.cc", 36 "android/blimp_contents_jni_registrar.cc",
34 "android/blimp_contents_jni_registrar.h", 37 "android/blimp_contents_jni_registrar.h",
35 "android/blimp_contents_observer_proxy.cc", 38 "android/blimp_contents_observer_proxy.cc",
36 "android/blimp_contents_observer_proxy.h", 39 "android/blimp_contents_observer_proxy.h",
37 "android/blimp_navigation_controller_impl_android.cc", 40 "android/blimp_navigation_controller_impl_android.cc",
38 "android/blimp_navigation_controller_impl_android.h", 41 "android/blimp_navigation_controller_impl_android.h",
39 ] 42 ]
40 43
41 deps = [ 44 deps = [
42 ":jni_headers", 45 ":jni_headers",
43 ] 46 ]
44 } 47 }
45 } 48 }
46 49
50 source_set("test_support") {
51 testonly = true
52
53 sources = [
54 "fake_navigation_feature.cc",
55 "fake_navigation_feature.h",
56 "mock_navigation_feature_delegate.cc",
57 "mock_navigation_feature_delegate.h",
58 ]
59
60 deps = [
61 "//skia",
62 "//url",
63 ]
64
65 public_deps = [
66 "//testing/gmock",
67 ]
68 }
69
47 source_set("unit_tests") { 70 source_set("unit_tests") {
48 visibility = [ "//blimp/client/core:unit_tests" ] 71 visibility = [ "//blimp/client/core:unit_tests" ]
49 72
50 testonly = true 73 testonly = true
51 74
52 sources = [ 75 sources = [
53 "blimp_contents_impl_unittest.cc", 76 "blimp_contents_impl_unittest.cc",
54 "blimp_navigation_controller_impl_unittest.cc", 77 "blimp_navigation_controller_impl_unittest.cc",
78 "navigation_feature_unittest.cc",
55 ] 79 ]
56 80
57 deps = [ 81 deps = [
58 ":contents", 82 ":contents",
83 ":test_support",
59 "//base", 84 "//base",
60 "//blimp/client/public:public_headers", 85 "//blimp/client/public:public_headers",
61 "//testing/gtest", 86 "//testing/gtest",
62 "//url", 87 "//url",
63 ] 88 ]
64 } 89 }
65 90
66 if (is_android) { 91 if (is_android) {
67 android_library("contents_java") { 92 android_library("contents_java") {
68 visibility = [ "//blimp/client/*" ] 93 visibility = [ "//blimp/client/*" ]
(...skipping 17 matching lines...) Expand all
86 sources = [ 111 sources = [
87 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.ja va", 112 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.ja va",
88 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java" , 113 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java" ,
89 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverPr oxy.java", 114 "android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverPr oxy.java",
90 "android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControll erImpl.java", 115 "android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControll erImpl.java",
91 ] 116 ]
92 117
93 jni_package = "blimp/client/core/contents" 118 jni_package = "blimp/client/core/contents"
94 } 119 }
95 } 120 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698