blimp/client/core/contents/android/blimp_contents_observer_proxy.cc - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: More kmarshall comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/android/blimp_contents_observer_proxy.h ('k') | blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h » ('j') | blimp/client/core/contents/blimp_navigation_controller_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

diff --git a/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc b/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

index 437d138372043e2e278e23cf7829a7f3b35630fd..61d668fce9984f9769e0f75eee803d86fd330ee3 100644

--- a/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

+++ b/blimp/client/core/contents/android/blimp_contents_observer_proxy.cc

@@ -47,14 +47,10 @@ void BlimpContentsObserverProxy::Destroy(

delete this;

}

-void BlimpContentsObserverProxy::OnURLUpdated(const GURL& url) {

+void BlimpContentsObserverProxy::OnNavigationStateChanged() {

JNIEnv* env = base::android::AttachCurrentThread();

- base::android::ScopedJavaLocalRef<jobject> obj(java_obj_);

- base::android::ScopedJavaLocalRef<jstring> jstring_url(

- base::android::ConvertUTF8ToJavaString(env, url.spec()));

- Java_BlimpContentsObserverProxy_onUrlUpdated(env, obj.obj(),

- jstring_url.obj());

+ Java_BlimpContentsObserverProxy_onNavigationStateChanged(env,

+ java_obj_.obj());

Kevin M 2016/08/03 16:55:15 This looks like Java-style formatting? Run "git cl

}

} // namespace client