blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: More kmarshall comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java

diff --git a/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java b/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java

index 27f29c8e1dae2e6f66cc0dd970ce6793f825d09c..84101c4a4929a3e915cf6e11c1f8940b25621cff 100644

--- a/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java

+++ b/blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java

@@ -24,9 +24,7 @@ public class BlimpContentsTest extends BlimpNativeInstrumentationTestCase {

private static class TestBlimpContentsObserver extends EmptyBlimpContentsObserver {

public String url;

@Override

- public void onUrlUpdated(String url) {

- this.url = url;

- }

+ public void onNavigationStateChanged() {}

}

private static void runUntilIdle() {

« no previous file with comments | « blimp/client/BUILD.gn ('k') | blimp/client/app/android/toolbar.h » ('j') | blimp/client/core/contents/android/blimp_contents_observer_proxy.cc » ('J')