blimp/client/BUILD.gn - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: More kmarshall comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java » ('j') | blimp/client/core/contents/android/blimp_contents_observer_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 8b908f5d07aeb050580191c6ffb793384f1b4dce..803ae4dd55604ddcfee883a6bfd0d10a096d56a9 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -25,6 +25,7 @@ source_set("session") {

":compositor",

"//base",

"//blimp/client/core/compositor",

+ "//blimp/client/core/contents",

"//blimp/client/core/session",

"//blimp/common",

"//blimp/common/proto",

@@ -92,8 +93,6 @@ source_set("feature") {

sources = [

"feature/ime_feature.cc",

"feature/ime_feature.h",

- "feature/navigation_feature.cc",

- "feature/navigation_feature.h",

"feature/render_widget_feature.cc",

"feature/render_widget_feature.h",

"feature/settings_feature.cc",

@@ -126,8 +125,6 @@ source_set("test_support") {

sources = [

"feature/mock_ime_feature_delegate.cc",

"feature/mock_ime_feature_delegate.h",

- "feature/mock_navigation_feature_delegate.cc",

- "feature/mock_navigation_feature_delegate.h",

"feature/mock_render_widget_feature_delegate.cc",

"feature/mock_render_widget_feature_delegate.h",

"session/test_client_session.cc",

@@ -197,7 +194,6 @@ source_set("feature_unit_tests") {

sources = [

"feature/compositor/blimp_compositor_manager_unittest.cc",

- "feature/navigation_feature_unittest.cc",

"feature/render_widget_feature_unittest.cc",

"feature/tab_control_feature_unittest.cc",

]