Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2059813002: Don't set a target library in whole-program mode. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
Kasper Lund, kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@type_parse_error
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M lib/src/run_batch.dart View 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (3 generated)
ahe
Without this, most tests would crash in batch mode when using --program (or not using ...
4 years, 6 months ago (2016-06-10 16:02:22 UTC) #2
kasperl
LGTM.
4 years, 6 months ago (2016-06-13 06:39:30 UTC) #4
ahe
4 years, 6 months ago (2016-06-15 10:16:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39ec14a1f119ba2a164042c6d2cc8ac09adbb5fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698