Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2058013003: Revert of Optimize render passes with single quads (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
CC:
bsalomon_chromium, cc-bugs_chromium.org, chromium-reviews, jbroman, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize render passes with single quads (patchset #13 id:240001 of https://codereview.chromium.org/1960543002/ ) Reason for revert: Context menu is broken on Linux: https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing BUG=619185 Original issue's description: > Optimize render passes with single quads > > Many effects (masks, replicas, filters) generate render passes for > simplicity in the code. However, in the cases where the pass contains a > single quad with a texture, that resulting texture could just be used as > the input texture instead of the render pass itself. > > The complication is mostly that render passes and tile textures are > flipped relative to each other (oops) and so some knowledge of this has > to leak into drawing render passes. > > This is done by detecting such render passes inside of DirectRenderer, > storing the TileQuad that would have been drawn, skipping allocating the > pass and rendering it, and then calling a slightly modified version of > DrawRenderPassQuad with the TileQuad's resource. The check for which > render passes can be supported is conservative to start. > > This optimization usually will not be supported on mac because skia > does not support textures with texture rectangle targets as input. > > BUG=254639, 606672 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232 > Cr-Commit-Position: refs/heads/master@{#399060} TBR=ericrk@chromium.org,senorblanco@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=254639, 606672 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea Cr-Commit-Position: refs/heads/master@{#399308}

Patch Set 1 #

Patch Set 2 : Added tests #

Patch Set 3 : Revert "Optimize render passes with single quads" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -243 lines) Patch
M cc/output/direct_renderer.h View 1 3 chunks +0 lines, -8 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 2 chunks +3 lines, -20 lines 0 comments Download
M cc/output/gl_renderer.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 11 chunks +29 lines, -113 lines 0 comments Download
M cc/test/data/rotated_drop_shadow_filter_gl.png View Binary file 0 comments Download
M cc/test/data/rotated_drop_shadow_filter_sw.png View Binary file 0 comments Download
M cc/test/solid_color_content_layer_client.h View 1 2 chunks +1 line, -11 lines 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 1 chunk +3 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 2 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-hw-expected.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (11 generated)
kozy
Created Revert of Optimize render passes with single quads
4 years, 6 months ago (2016-06-10 22:03:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058013003/1
4 years, 6 months ago (2016-06-10 22:04:55 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-10 22:05:37 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 22:06:07 UTC) #7
danakj
Does the context menu use multiple render passes? --ui-show-layer-borders will give layers borders. Blue means ...
4 years, 6 months ago (2016-06-10 22:10:31 UTC) #9
danakj
On 2016/06/10 22:10:31, danakj wrote: > Does the context menu use multiple render passes? --ui-show-layer-borders ...
4 years, 6 months ago (2016-06-10 22:11:16 UTC) #10
kozy
On 2016/06/10 22:10:31, danakj wrote: > Does the context menu use multiple render passes? --ui-show-layer-borders ...
4 years, 6 months ago (2016-06-10 22:15:24 UTC) #11
danakj
On Fri, Jun 10, 2016 at 3:15 PM, <kozyatinskiy@chromium.org> wrote: > On 2016/06/10 22:10:31, danakj ...
4 years, 6 months ago (2016-06-10 22:17:54 UTC) #12
kozy
On 2016/06/10 22:17:54, danakj wrote: > On Fri, Jun 10, 2016 at 3:15 PM, <mailto:kozyatinskiy@chromium.org> ...
4 years, 6 months ago (2016-06-10 22:21:56 UTC) #14
danakj
On Fri, Jun 10, 2016 at 3:21 PM, <kozyatinskiy@chromium.org> wrote: > On 2016/06/10 22:17:54, danakj ...
4 years, 6 months ago (2016-06-10 22:26:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058013003/270001
4 years, 6 months ago (2016-06-10 22:37:26 UTC) #18
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-10 22:38:06 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 22:38:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058013003/290001
4 years, 6 months ago (2016-06-10 22:52:02 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:290001)
4 years, 6 months ago (2016-06-10 22:52:52 UTC) #25
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 22:54:42 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea
Cr-Commit-Position: refs/heads/master@{#399308}

Powered by Google App Engine
This is Rietveld 408576698