Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: cc/output/direct_renderer.cc

Issue 2058013003: Revert of Optimize render passes with single quads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert "Optimize render passes with single quads" Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/direct_renderer.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/direct_renderer.h" 5 #include "cc/output/direct_renderer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <unordered_map> 9 #include <unordered_map>
10 #include <utility> 10 #include <utility>
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 ResourceProvider* resource_provider) 134 ResourceProvider* resource_provider)
135 : Renderer(client, settings), 135 : Renderer(client, settings),
136 output_surface_(output_surface), 136 output_surface_(output_surface),
137 resource_provider_(resource_provider), 137 resource_provider_(resource_provider),
138 overlay_processor_(new OverlayProcessor(output_surface)) { 138 overlay_processor_(new OverlayProcessor(output_surface)) {
139 overlay_processor_->Initialize(); 139 overlay_processor_->Initialize();
140 } 140 }
141 141
142 DirectRenderer::~DirectRenderer() {} 142 DirectRenderer::~DirectRenderer() {}
143 143
144 const TileDrawQuad* DirectRenderer::CanPassBeDrawnDirectly(
145 const RenderPass* pass) {
146 return nullptr;
147 }
148
149 void DirectRenderer::DecideRenderPassAllocationsForFrame( 144 void DirectRenderer::DecideRenderPassAllocationsForFrame(
150 const RenderPassList& render_passes_in_draw_order) { 145 const RenderPassList& render_passes_in_draw_order) {
151 render_pass_bypass_quads_.clear();
152
153 std::unordered_map<RenderPassId, gfx::Size, RenderPassIdHash> 146 std::unordered_map<RenderPassId, gfx::Size, RenderPassIdHash>
154 render_passes_in_frame; 147 render_passes_in_frame;
155 for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i) { 148 for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i)
156 RenderPass* pass = render_passes_in_draw_order[i].get();
157 if (const TileDrawQuad* tile_quad = CanPassBeDrawnDirectly(pass)) {
158 render_pass_bypass_quads_[pass->id] = *tile_quad;
159 continue;
160 }
161 render_passes_in_frame.insert(std::pair<RenderPassId, gfx::Size>( 149 render_passes_in_frame.insert(std::pair<RenderPassId, gfx::Size>(
162 pass->id, RenderPassTextureSize(pass))); 150 render_passes_in_draw_order[i]->id,
163 } 151 RenderPassTextureSize(render_passes_in_draw_order[i].get())));
164 152
165 std::vector<RenderPassId> passes_to_delete; 153 std::vector<RenderPassId> passes_to_delete;
166 for (auto pass_iter = render_pass_textures_.begin(); 154 for (auto pass_iter = render_pass_textures_.begin();
167 pass_iter != render_pass_textures_.end(); ++pass_iter) { 155 pass_iter != render_pass_textures_.end(); ++pass_iter) {
168 auto it = render_passes_in_frame.find(pass_iter->first); 156 auto it = render_passes_in_frame.find(pass_iter->first);
169 if (it == render_passes_in_frame.end()) { 157 if (it == render_passes_in_frame.end()) {
170 passes_to_delete.push_back(pass_iter->first); 158 passes_to_delete.push_back(pass_iter->first);
171 continue; 159 continue;
172 } 160 }
173 161
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 BspTree bsp_tree(poly_list); 398 BspTree bsp_tree(poly_list);
411 BspWalkActionDrawPolygon action_handler(this, frame, render_pass_scissor, 399 BspWalkActionDrawPolygon action_handler(this, frame, render_pass_scissor,
412 use_render_pass_scissor); 400 use_render_pass_scissor);
413 bsp_tree.TraverseWithActionHandler(&action_handler); 401 bsp_tree.TraverseWithActionHandler(&action_handler);
414 DCHECK(poly_list->empty()); 402 DCHECK(poly_list->empty());
415 } 403 }
416 404
417 void DirectRenderer::DrawRenderPassAndExecuteCopyRequests( 405 void DirectRenderer::DrawRenderPassAndExecuteCopyRequests(
418 DrawingFrame* frame, 406 DrawingFrame* frame,
419 RenderPass* render_pass) { 407 RenderPass* render_pass) {
420 if (render_pass_bypass_quads_.find(render_pass->id) !=
421 render_pass_bypass_quads_.end()) {
422 return;
423 }
424
425 DrawRenderPass(frame, render_pass); 408 DrawRenderPass(frame, render_pass);
426 409
427 bool first_request = true; 410 bool first_request = true;
428 for (auto& copy_request : render_pass->copy_requests) { 411 for (auto& copy_request : render_pass->copy_requests) {
429 // Doing a readback is destructive of our state on Mac, so make sure 412 // Doing a readback is destructive of our state on Mac, so make sure
430 // we restore the state between readbacks. http://crbug.com/99393. 413 // we restore the state between readbacks. http://crbug.com/99393.
431 if (!first_request) 414 if (!first_request)
432 UseRenderPass(frame, render_pass); 415 UseRenderPass(frame, render_pass);
433 CopyCurrentRenderPassToBitmap(frame, std::move(copy_request)); 416 CopyCurrentRenderPassToBitmap(frame, std::move(copy_request));
434 first_request = false; 417 first_request = false;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 auto iter = render_pass_textures_.find(id); 554 auto iter = render_pass_textures_.find(id);
572 return iter != render_pass_textures_.end() && iter->second->id(); 555 return iter != render_pass_textures_.end() && iter->second->id();
573 } 556 }
574 557
575 // static 558 // static
576 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) { 559 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) {
577 return render_pass->output_rect.size(); 560 return render_pass->output_rect.size();
578 } 561 }
579 562
580 } // namespace cc 563 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/direct_renderer.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698