Add isolate tag-profile and better handling of errors

Add isolate tag-profile model and UI.
Distinction between a Dart Error and a ServiceError/ServiceException.
Better Observatory behaviour when a ServiceError/ServiceExceptions occurs.
Display isolate's sticky error.

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34377

[turnidge, 2014-03-24 20:22:13]

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/isolate_view.html (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/isolate_view.html:84: <h1>Sticky
Error</h1>
Let's drop the word sticky here - not so meaningful to the user.

Maybe just Error?  Change the json property name to 'error' too.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:117: }
Maybe just drop _created() entirely.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:265: }, test: (e) => e
is ServiceError).catchError((exception) {
I hadn't seen the "test" stuff before.  Wacky!

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:366: }
What do you think of us moving the profilng helper classes out of object.dart
later?  Not for this review - would conflict too horribly with my change.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:742: // TODO:
stackTrace?
Delete this TODO?

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:931: jsobj.AddProperty("stickyError", error, false);
rename to "error"?

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:956: vm_tag_counters_.Increment(vm_tag());
Is the vm_tag always the kIdleTagId here?  Or are there other possibilities?

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1611: }
How do you use these currently?  Just curious.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service/runni...
File runtime/vm/service/running_isolates.dart (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service/runni...
runtime/vm/service/running_isolates.dart:43: isolateId = _rootPortId;
so isolates/root is an alias to whatever the root isolate's id is?

Not sure that this works so well, post my change.  Whenever we see an isolate we
don't recognize, we reload the VM rather than just trusting the id and reloading
the isolate.  You may want to drop this feature and we can add it later.

Another option is to suport "root" in the Observatory itself.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/tags.cc
File runtime/vm/tags.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:78: }
So you split the message into two parallel arrays?

Efficiency isn't really an issue, given that we have very few tags, so you may
want to consider object-per-tag format for human readability.

Up to you.

[Cutch, 2014-03-25 14:39:06]

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/isolate_view.html (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/isolate_view.html:84: <h1>Sticky
Error</h1>
On 2014/03/24 20:22:13, turnidge wrote:
> Let's drop the word sticky here - not so meaningful to the user.
> 
> Maybe just Error?  Change the json property name to 'error' too.

Done.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:117: }
On 2014/03/24 20:22:13, turnidge wrote:
> Maybe just drop _created() entirely.

Done.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:366: }
On 2014/03/24 20:22:13, turnidge wrote:
> What do you think of us moving the profilng helper classes out of object.dart
> later?  Not for this review - would conflict too horribly with my change.

sgtm.

https://codereview.chromium.org/205713004/diff/20001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:742: // TODO:
stackTrace?
On 2014/03/24 20:22:13, turnidge wrote:
> Delete this TODO?

Done.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:931: jsobj.AddProperty("stickyError", error, false);
On 2014/03/24 20:22:13, turnidge wrote:
> rename to "error"?

Done.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:956: vm_tag_counters_.Increment(vm_tag());
On 2014/03/24 20:22:13, turnidge wrote:
> Is the vm_tag always the kIdleTagId here?  Or are there other possibilities?

It will always be kIdleTagId or kVMTagId (there is a race because we update the
tag without taking any locks).

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1611: }
On 2014/03/24 20:22:13, turnidge wrote:
> How do you use these currently?  Just curious.

I am manually using these to test error handling in Observatory.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service/runni...
File runtime/vm/service/running_isolates.dart (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/service/runni...
runtime/vm/service/running_isolates.dart:43: isolateId = _rootPortId;
On 2014/03/24 20:22:13, turnidge wrote:
> so isolates/root is an alias to whatever the root isolate's id is?
> 
> Not sure that this works so well, post my change.  Whenever we see an isolate
we
> don't recognize, we reload the VM rather than just trusting the id and
reloading
> the isolate.  You may want to drop this feature and we can add it later.
> 
> Another option is to suport "root" in the Observatory itself.

This alias will never been seen by Observatory, it's primarily useful for
testing from the command line. I'd like to keep this in for now.

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/tags.cc
File runtime/vm/tags.cc (right):

https://codereview.chromium.org/205713004/diff/20001/runtime/vm/tags.cc#newco...
runtime/vm/tags.cc:78: }
On 2014/03/24 20:22:13, turnidge wrote:
> So you split the message into two parallel arrays?
> 
> Efficiency isn't really an issue, given that we have very few tags, so you may
> want to consider object-per-tag format for human readability.
> 
> Up to you.

I would prefer to keep them as separate arrays. Makes operating on them easier.

[turnidge, 2014-03-25 17:52:53]

lgtm, w/ one minor comment.

https://codereview.chromium.org/205713004/diff/50001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/205713004/diff/50001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:682: 
Extra blank line.

[Cutch, 2014-03-25 18:01:52]

https://codereview.chromium.org/205713004/diff/50001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/205713004/diff/50001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/object.dart:682: 
On 2014/03/25 17:52:53, turnidge wrote:
> Extra blank line.

Done.

[Cutch, 2014-03-25 18:09:19]

Committed patchset #5 manually as r34377 (presubmit successful).