Add isolate tag-profile and better handling of errors

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "lib/mirrors.h"
@@ skipping 350 matching lines @@
   ASSERT(deopt_context_ == NULL);  // No deopt in progress when isolate deleted.
   delete spawn_state_;
 }
 
 
 void Isolate::SetCurrent(Isolate* current) {
   Isolate* old_current = Current();
   if (old_current != NULL) {
     old_current->set_thread_state(NULL);
     Profiler::EndExecution(old_current);
+    old_current->set_vm_tag(VMTag::kIdleTagId);
   }
   Thread::SetThreadLocal(isolate_key, reinterpret_cast<uword>(current));
   if (current != NULL) {
+    current->set_vm_tag(VMTag::kVMTagId);
     ASSERT(current->thread_state() == NULL);
     InterruptableThreadState* thread_state =
         ThreadInterrupter::GetCurrentThreadState();
 #if defined(DEBUG)
     CheckForDuplicateThreadState(thread_state);
 #endif
     Profiler::BeginExecution(current);
     current->set_thread_state(thread_state);
   }
 }
@@ skipping 532 matching lines @@
   jsobj.AddProperty("controlPorts", control_ports);
   jsobj.AddProperty("pausedOnStart", pause_on_start);
   jsobj.AddProperty("pausedOnExit", paused_on_exit);
   jsobj.AddProperty("pauseOnExit", pause_on_exit);
   const Library& lib =
       Library::Handle(object_store()->root_library());
   jsobj.AddProperty("rootLib", lib);
 
   timer_list().PrintTimersToJSONProperty(&jsobj);
 
+  if (object_store()->sticky_error() != Object::null()) {
+    Error& error = Error::Handle(this, object_store()->sticky_error());
+    ASSERT(!error.IsNull());
+    jsobj.AddProperty("stickyError", error, false);

[turnidge, 2014/03/24 20:22:13]

rename to "error"?

[Cutch, 2014/03/25 14:39:06]

Done.

+  }
+
   {
     JSONObject typeargsRef(&jsobj, "canonicalTypeArguments");
     typeargsRef.AddProperty("type", "@TypeArgumentsList");
     typeargsRef.AddProperty("id", "typearguments");
     typeargsRef.AddProperty("name", "canonical type arguments");
   }
 }
 
 
+void Isolate::ProfileInterrupt() {
+  InterruptableThreadState* state = thread_state();
+  if (state == NULL) {
+    // Isolate is not scheduled on a thread.
+    ProfileIdle();
+    return;
+  }
+  ASSERT(state->id != Thread::kInvalidThreadId);
+  ThreadInterrupter::InterruptThread(state);
+}
+
+
+void Isolate::ProfileIdle() {
+  vm_tag_counters_.Increment(vm_tag());

[turnidge, 2014/03/24 20:22:13]

Is the vm_tag always the kIdleTagId here?  Or are there other possibilities?

[Cutch, 2014/03/25 14:39:06]

It will always be kIdleTagId or kVMTagId (there is a race because we update the
tag without taking any locks).

+}
+
+
 void Isolate::VisitIsolates(IsolateVisitor* visitor) {
   if (visitor == NULL) {
     return;
   }
   MonitorLocker ml(isolates_list_monitor_);
   Isolate* current = isolates_list_head_;
   while (current) {
     visitor->VisitIsolate(current);
     current = current->next_;
   }
@@ skipping 149 matching lines @@
   return func.raw();
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(isolate());
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart