Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: runtime/bin/vmservice/client/lib/service_html.dart

Issue 205713004: Add isolate tag-profile and better handling of errors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/service_html.dart
diff --git a/runtime/bin/vmservice/client/lib/service_html.dart b/runtime/bin/vmservice/client/lib/service_html.dart
index 5a5a9231841e760e664dc262e7b8d94023046235..bd611a55e666700ea0433804f6863a00e3fae4f5 100644
--- a/runtime/bin/vmservice/client/lib/service_html.dart
+++ b/runtime/bin/vmservice/client/lib/service_html.dart
@@ -36,13 +36,15 @@ class HttpVM extends VM {
return HttpRequest.getString(host + id).catchError((error) {
// If we get an error here, the network request has failed.
Logger.root.severe('HttpRequest.getString failed.');
+ var request = error.target;
return JSON.encode({
- 'type': 'Error',
+ 'type': 'ServiceException',
'id': '',
- 'kind': 'NetworkError',
+ 'response': error.target.responseText,
+ 'kind': 'NetworkException',
'message': 'Could not connect to service. Check that you started the'
' VM with the following flags:\n --enable-vm-service'
- ' --pin-isolates'
+ ' --pause-isolates-on-exit'
});
});
}
« no previous file with comments | « runtime/bin/vmservice/client/lib/elements.html ('k') | runtime/bin/vmservice/client/lib/src/app/application.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698