Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 205713002: Add a basic demo mode browser test. (Closed)

Created:
6 years, 9 months ago by rkc
Modified:
6 years, 9 months ago
Reviewers:
bartfab (slow), xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, bartfab (slow)
Visibility:
Public.

Description

Add a basic demo mode browser test. This CL adds a basic demo mode browser test that verifies that a machine with 0 derelict timeouts correctly brings up the demo app. This CL also fixes a bunch of style issues pointed out in R=bartfab@chromium.org, xiyuan@chromium.org BUG=343574, 355134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260255

Patch Set 1 #

Total comments: 72

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 38

Patch Set 5 : #

Total comments: 6

Patch Set 6 : #

Total comments: 14

Patch Set 7 : #

Patch Set 8 : fix license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -103 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.h View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/idle_detector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/idle_detector.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/authenticator.h View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 2 3 4 3 chunks +32 lines, -9 lines 0 comments Download
A chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc View 1 2 3 4 5 6 1 chunk +91 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 4 chunks +3 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_authenticator.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_authenticator.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.h View 1 2 3 4 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 2 3 4 5 6 3 chunks +25 lines, -6 lines 0 comments Download
A chrome/browser/chromeos/login/test/app_window_waiter.h View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/test/app_window_waiter.cc View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 4 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/demo_app/html/main.html View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A + chrome/test/data/chromeos/demo_app/js/background.js View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
rkc
6 years, 9 months ago (2014-03-19 23:42:39 UTC) #1
xiyuan
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/idle_detector.h File chrome/browser/chromeos/idle_detector.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/idle_detector.h#newcode10 chrome/browser/chromeos/idle_detector.h:10: #include "base/callback.h" nit: callback_forward.h here and callback.h in cc ...
6 years, 9 months ago (2014-03-20 01:14:03 UTC) #2
xiyuan
more nits. https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc File chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode5 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:5: #include "apps/app_window_registry.h" seems not used. https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode9 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:9: ...
6 years, 9 months ago (2014-03-20 04:59:54 UTC) #3
bartfab (slow)
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, Why is this being renamed from |ephemeral| ...
6 years, 9 months ago (2014-03-20 13:22:29 UTC) #4
rkc
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/20 13:22:29, bartfab wrote: > Why ...
6 years, 9 months ago (2014-03-20 21:45:01 UTC) #5
xiyuan
lgtm https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc File chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode48 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:48: PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir); On 2014/03/20 21:45:01, Rahul Chaturvedi wrote: ...
6 years, 9 months ago (2014-03-20 21:59:44 UTC) #6
rkc
https://codereview.chromium.org/205713002/diff/20001/chrome/test/data/chromeos/demo_app/js/background.js File chrome/test/data/chromeos/demo_app/js/background.js (right): https://codereview.chromium.org/205713002/diff/20001/chrome/test/data/chromeos/demo_app/js/background.js#newcode8 chrome/test/data/chromeos/demo_app/js/background.js:8: console.log('Demo app launched.'); On 2014/03/20 21:59:44, xiyuan wrote: > ...
6 years, 9 months ago (2014-03-20 22:04:45 UTC) #7
bartfab (slow)
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/20 21:45:01, Rahul Chaturvedi wrote: > ...
6 years, 9 months ago (2014-03-21 10:37:31 UTC) #8
xiyuan
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/21 10:37:32, bartfab wrote: > On ...
6 years, 9 months ago (2014-03-21 16:38:16 UTC) #9
rkc
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/21 10:37:32, bartfab wrote: > On ...
6 years, 9 months ago (2014-03-21 23:31:18 UTC) #10
xiyuan
Don't forget to upload latest patch.
6 years, 9 months ago (2014-03-21 23:53:30 UTC) #11
rkc
On 2014/03/21 23:53:30, xiyuan wrote: > Don't forget to upload latest patch. Whoops, it was ...
6 years, 9 months ago (2014-03-21 23:57:13 UTC) #12
xiyuan
https://codereview.chromium.org/205713002/diff/60001/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc File chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc (right): https://codereview.chromium.org/205713002/diff/60001/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc#newcode165 chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc:165: context.username_hash = context.username + "- demouserhashfakevalue"; nit: strip the ...
6 years, 9 months ago (2014-03-22 04:02:42 UTC) #13
bartfab (slow)
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/21 23:31:18, Rahul Chaturvedi wrote: > ...
6 years, 9 months ago (2014-03-25 12:52:54 UTC) #14
rkc
https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/205713002/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode37 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:37: bool force_guest, On 2014/03/25 12:52:54, bartfab wrote: > On ...
6 years, 9 months ago (2014-03-26 21:30:40 UTC) #15
xiyuan
lgtm https://codereview.chromium.org/205713002/diff/80001/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc File chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc (right): https://codereview.chromium.org/205713002/diff/80001/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode36 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:36: content::NotificationService::AllSources()).Wait(); nit: Wrap with enclosing {} since it ...
6 years, 9 months ago (2014-03-26 21:58:18 UTC) #16
rkc
https://codereview.chromium.org/205713002/diff/80001/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc File chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc (right): https://codereview.chromium.org/205713002/diff/80001/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode36 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:36: content::NotificationService::AllSources()).Wait(); On 2014/03/26 21:58:19, xiyuan wrote: > nit: Wrap ...
6 years, 9 months ago (2014-03-26 22:26:11 UTC) #17
bartfab (slow)
LGTM. Thanks for working on this. Great to see demo mode covered by a test ...
6 years, 9 months ago (2014-03-27 14:13:28 UTC) #18
rkc
https://codereview.chromium.org/205713002/diff/80002/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc File chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc (right): https://codereview.chromium.org/205713002/diff/80002/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc#newcode67 chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc:67: bool VerifyDemoAppLaunch() { On 2014/03/27 14:13:29, bartfab wrote: > ...
6 years, 9 months ago (2014-03-27 21:43:10 UTC) #19
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 9 months ago (2014-03-27 21:43:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/205713002/110001
6 years, 9 months ago (2014-03-27 21:46:12 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:11:09 UTC) #22
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58101
6 years, 9 months ago (2014-03-27 22:11:10 UTC) #23
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 9 months ago (2014-03-27 22:19:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/205713002/130001
6 years, 9 months ago (2014-03-27 22:22:02 UTC) #25
rkc
6 years, 9 months ago (2014-03-28 20:16:58 UTC) #26
Message was sent while issue was closed.
Committed patchset #8 manually as r260255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698