Add a basic demo mode browser test.

chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/app_mode/kiosk_profile_loader.h"
 
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
@@ skipping 99 matching lines @@
   int retry_count_;
 
   DISALLOW_COPY_AND_ASSIGN(CryptohomedChecker);
 };
 
 
 ////////////////////////////////////////////////////////////////////////////////
 // KioskProfileLoader
 
 KioskProfileLoader::KioskProfileLoader(const std::string& app_user_id,
-                                       bool force_ephemeral,
+                                       bool force_guest,
                                        Delegate* delegate)
     : user_id_(app_user_id),
-      force_ephemeral_(force_ephemeral),
+      force_guest_(force_guest),
       delegate_(delegate) {}
 
 KioskProfileLoader::~KioskProfileLoader() {}
 
 void KioskProfileLoader::Start() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   login_performer_.reset();
   cryptohomed_checker_.reset(new CryptohomedChecker(this));
   cryptohomed_checker_->StartCheck();
 }
 
 void KioskProfileLoader::LoginAsKioskAccount() {
   login_performer_.reset(new LoginPerformer(this));
-  login_performer_->LoginAsKioskAccount(user_id_, force_ephemeral_);
+  login_performer_->LoginAsKioskAccount(user_id_, force_guest_);
 }
 
 void KioskProfileLoader::ReportLaunchResult(KioskAppLaunchError::Error error) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (error != KioskAppLaunchError::NONE) {
     delegate_->OnProfileLoadFailed(error);
   }
 }
 
 void KioskProfileLoader::OnLoginSuccess(const UserContext& user_context)  {
   // LoginPerformer will delete itself.
   login_performer_->set_delegate(NULL);
   ignore_result(login_performer_.release());
 
   // If we are launching a demo session, we need to start MountGuest with the
   // guest username; this is because there are several places in the cros code
   // which rely on the username sent to cryptohome to be $guest. Back in Chrome
   // we switch this back to the demo user name to correctly identify this
   // user as a demo user.
   UserContext context = user_context;
-  if (context.username == UserManager::kGuestUserName)
+  if (context.username == UserManager::kGuestUserName) {
     context.username = DemoAppLauncher::kDemoUserName;
+    // We can't have an empty hash. Currently mounting guest does not actually
+    // give us a user hash; the way we deal with this for Guest Mode is by
+    // setting a fake hash value. This needs to be fixed, see crbug.com/355134.
+    if (context.username_hash.empty())
+      context.username_hash = context.username + "- demouserhashfakevalue";

[xiyuan, 2014/03/22 04:02:42]

nit: strip the space between "-" and the suffix.

[bartfab (slow), 2014/03/25 12:52:54]

1) Why not simply use "demouserhashfakevalue" as the hash, without any
concatenation? You only support a single user name here anyway.
2) Why is this a conditional? Can it ever happen that the hash *is* set already?

[rkc, 2014/03/26 21:30:40]

So this wasn't really a good solution to go with. After reading the comments on
crbug.com/355134, it became apparent that using a fake hash is not the correct
thing to do. Instead I've changed the code to now actually fetch the real
username hash from Crypto home. This code has been removed.

[rkc, 2014/03/26 21:30:40]

Code removed.

+  }
   LoginUtils::Get()->PrepareProfile(context,
                                     std::string(),  // display email
                                     false,  // has_cookies
                                     false,  // has_active_session
                                     this);
 }
 
 void KioskProfileLoader::OnLoginFailure(const LoginFailure& error) {
   ReportLaunchResult(LoginFailureToKioskAppLaunchError(error));
 }
@@ skipping 14 matching lines @@
 void KioskProfileLoader::OnProfilePrepared(Profile* profile) {
   // This object could be deleted any time after successfully reporting
   // a profile load, so invalidate the LoginUtils delegate now.
   LoginUtils::Get()->DelegateDeleted(this);
 
   delegate_->OnProfileLoaded(profile);
   ReportLaunchResult(KioskAppLaunchError::NONE);
 }
 
 }  // namespace chromeos