Add a basic demo mode browser test.

chrome/browser/chromeos/login/parallel_authenticator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 114 matching lines @@
   // Initiates incognito ("browse without signing in") login.
   // Mounts tmpfs and notifies consumer on the success/failure.
   virtual void LoginOffTheRecord() OVERRIDE;
 
   // Initiates login into the public account identified by |username|.
   // Mounts an ephemeral cryptohome and notifies consumer on the
   // success/failure.
   virtual void LoginAsPublicAccount(const std::string& username) OVERRIDE;
 
   // Initiates login into the kiosk mode account identified by |app_user_id|.
-  // Mounts an public but non-ephemeral cryptohome and notifies consumer on the
-  // success/failure.
-  virtual void LoginAsKioskAccount(
-      const std::string& app_user_id, bool force_ephemeral) OVERRIDE;
+  // Mounts a public cryptohome and notifies the consumer on the
+  // success/failure. If |force_guest| is true, instead we mount a guest
+  // cryptohome (which is ephemeral), otherwise the mount is non-ephemeral.
+  // If the |DeviceEphemeralUsersEnabled| policy is enabled, even if
+  // force_guest is false, a (non-guest) ephemeral cryptohome will be mounted.

[bartfab (slow), 2014/03/25 12:52:54]

This looks correct but a bit convoluted, in that it states that the mount
normally is non-ephemeral but then immediately contradicts that statement under
certain conditions. How about something along the lines of (with |force_guest|
replaced by |use_guest_mount|, as suggested elsewhere):

Mounts an ephemeral guest cryptohome if |use_guest_mount| is |true|. Otherwise,
mounts a public cryptohome, which will be ephemeral if the
|DeviceEphemeralUsersEnabled| policy is enabled and non-ephemeral otherwise.

[rkc, 2014/03/26 21:30:40]

Done.

+  virtual void LoginAsKioskAccount(const std::string& app_user_id,
+                                   bool force_guest) OVERRIDE;
 
   // These methods must be called on the UI thread, as they make DBus calls
   // and also call back to the login UI.
   virtual void OnRetailModeLoginSuccess() OVERRIDE;
   virtual void OnLoginSuccess() OVERRIDE;
   virtual void OnLoginFailure(const LoginFailure& error) OVERRIDE;
   virtual void RecoverEncryptedData(
       const std::string& old_password) OVERRIDE;
   virtual void ResyncEncryptedData() OVERRIDE;
 
@@ skipping 95 matching lines @@
   // When |remove_user_data_on_failure_| is set, we delay calling
   // consumer_->OnLoginFailure() until we removed the user cryptohome.
   const LoginFailure* delayed_login_failure_;
 
   DISALLOW_COPY_AND_ASSIGN(ParallelAuthenticator);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_PARALLEL_AUTHENTICATOR_H_