Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2056663004: Move xfa/fxjse/ to fxjse/ (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move xfa/fxjse/ to fxjse/ This makes it clear that fxjse/ is a standalone component and should not be entangled with other xfa/ components. BUG=pdfium:506 Committed: https://pdfium.googlesource.com/pdfium/+/8bd9ce00a0755d72c9b5b8ad43d8f50c2f51e5c5

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1910 lines) Patch
M BUILD.gn View 3 chunks +25 lines, -29 lines 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 1 chunk +1 line, -1 line 0 comments Download
A fxjse/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + fxjse/class.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + fxjse/context.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + fxjse/context.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fxjse/dynprop.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fxjse/include/cfxjse_arguments.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + fxjse/include/cfxjse_class.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + fxjse/include/cfxjse_value.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + fxjse/include/fxjse.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fxjse/runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fxjse/runtime.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fxjse/scope_inline.h View 2 chunks +6 lines, -8 lines 0 comments Download
A + fxjse/value.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa.gyp View 2 chunks +20 lines, -28 lines 0 comments Download
A xfa/fxfa/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_valuearray.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 2 chunks +1 line, -1 line 0 comments Download
D xfa/fxjse/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D xfa/fxjse/cfxjse_arguments.h View 1 chunk +0 lines, -38 lines 0 comments Download
D xfa/fxjse/class.h View 1 chunk +0 lines, -44 lines 0 comments Download
D xfa/fxjse/class.cpp View 1 chunk +0 lines, -282 lines 0 comments Download
D xfa/fxjse/context.h View 1 chunk +0 lines, -63 lines 0 comments Download
D xfa/fxjse/context.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
D xfa/fxjse/dynprop.cpp View 1 chunk +0 lines, -223 lines 0 comments Download
D xfa/fxjse/include/fxjse.h View 1 chunk +0 lines, -74 lines 0 comments Download
D xfa/fxjse/runtime.h View 1 chunk +0 lines, -46 lines 0 comments Download
D xfa/fxjse/runtime.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D xfa/fxjse/scope_inline.h View 1 chunk +0 lines, -77 lines 0 comments Download
D xfa/fxjse/value.h View 1 chunk +0 lines, -284 lines 0 comments Download
D xfa/fxjse/value.cpp View 1 chunk +0 lines, -297 lines 0 comments Download

Dependent Patchsets:

Issue 2053043002 Patch 1

Messages

Total messages: 11 (4 generated)
dsinclair
What do you think?
4 years, 6 months ago (2016-06-09 19:18:58 UTC) #2
Tom Sepez
sgtm
4 years, 6 months ago (2016-06-09 19:23:38 UTC) #3
dsinclair
In that case, PTAL, heh.
4 years, 6 months ago (2016-06-09 19:26:14 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2056663004/diff/1/fxjse/DEPS File fxjse/DEPS (right): https://codereview.chromium.org/2056663004/diff/1/fxjse/DEPS#newcode3 fxjse/DEPS:3: # TODO(dsinclair): Layering violation. XFA can't include FPDFSDK. ...
4 years, 6 months ago (2016-06-09 20:08:22 UTC) #5
dsinclair
https://codereview.chromium.org/2056663004/diff/1/fxjse/DEPS File fxjse/DEPS (right): https://codereview.chromium.org/2056663004/diff/1/fxjse/DEPS#newcode3 fxjse/DEPS:3: # TODO(dsinclair): Layering violation. XFA can't include FPDFSDK. On ...
4 years, 6 months ago (2016-06-09 20:11:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056663004/20001
4 years, 6 months ago (2016-06-09 20:11:48 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:24:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8bd9ce00a0755d72c9b5b8ad43d8f50c2f51...

Powered by Google App Engine
This is Rietveld 408576698