Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2053043002: Untangle bad depdenency from fxjse/ to fpdfsdk/ (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@move_fxjse
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Untangle bad depdenency from fxjse/ to fpdfsdk/ This CL moves the pieces of fpdfsdk/jsapi that were being used by fxjse/ to to the fxjse/ layer and uses those from fpdfsdk/. BUG=pdfium:506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -164 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + fpdfsdk/jsapi/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 5 chunks +3 lines, -76 lines 0 comments Download
M fpdfsdk/jsapi/include/fxjs_v8.h View 3 chunks +1 line, -85 lines 0 comments Download
M fxjse/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A fxjse/fxjs_perisolatedata.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
A fxjse/include/fxjs_perisolatedata.h View 1 chunk +166 lines, -0 lines 0 comments Download
M fxjse/runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/js_embedder_test.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
dsinclair
Thoughts? This feels pretty heavy handed but it straightens out the layering. This isn't commitable ...
4 years, 6 months ago (2016-06-09 20:25:14 UTC) #1
dsinclair
See previous message for notes, forgot to add reviewers, heh.
4 years, 6 months ago (2016-06-09 20:48:20 UTC) #3
Lei Zhang
I defer to Tom on javascripty stuff.
4 years, 6 months ago (2016-06-09 20:50:46 UTC) #4
Tom Sepez
On 2016/06/09 20:50:46, Lei Zhang (Slow) wrote: > I defer to Tom on javascripty stuff. ...
4 years, 6 months ago (2016-06-09 21:15:18 UTC) #5
dsinclair
4 years, 6 months ago (2016-06-09 23:40:23 UTC) #6
On 2016/06/09 21:15:18, Tom Sepez wrote:
> On 2016/06/09 20:50:46, Lei Zhang (Slow) wrote:
> > I defer to Tom on javascripty stuff.
> 
> Not quite.  FXJSE can depend on FXJS but not the other way around.
> In some sense, FXJS should be a parallel component to FXJSE both of which
> encapsulate v8.
> sdk -> fxjs (and fxjse in theory from the xfa crap in sdk but hopefully not)
> xfa -> fxjse
> fxjse -> fxjs
> fxjs -> v8
> fxjse -> v8

 K, I'll move fpdfsdk/jsapi up to fxjs/ and then everything should be fine as
the dependency goes the right way.

Powered by Google App Engine
This is Rietveld 408576698