fxjse/DEPS - Issue 2056663004: Move xfa/fxjse/ to fxjse/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fxjse/DEPS

Issue 2056663004: Move xfa/fxjse/ to fxjse/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 '+core/fxcrt/include',

2 # TODO(dsinclair): Layering violation. XFA can't include FPDFSDK.	3 # TODO(dsinclair): Layering violation. XFA can't include FPDFSDK.
	Tom Sepez 2016/06/09 20:08:22 Is it still a violation? Probably. But less so. Is it still a violation? Probably. But less so. Update comment to say fxjse instead of XFA. dsinclair 2016/06/09 20:11:24 Done. Yea, still a violation, fxjse/ is below fpd Show quoted text On 2016/06/09 20:08:22, Tom Sepez wrote: > Is it still a violation? Probably. But less so. > Update comment to say fxjse instead of XFA. Done. Yea, still a violation, fxjse/ is below fpdfsdk/ in layering.
3 '+fpdfsdk/jsapi/include',	4 '+fpdfsdk/jsapi/include',

4 '+v8/include',	5 '+v8/include',

5 ]	6 ]

OLD	NEW

« no previous file with comments | « fpdfsdk/javascript/ijs_runtime.h ('k') | fxjse/class.cpp » ('j') | no next file with comments »