Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2056483002: Move quads.mojom from Mus to cc (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move quads.mojom from Mus to cc This CL moves quads.mojom closer to the types they will map to along with other cc mojoms. This CL also updates the module name to cc.mojom, and updates Pass => RenderPass, Quad => DrawQuad to better match cc naming. BUG=611802 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/10bd63df0dbbc74da797c7d919d8c5461e947ff5 Cr-Commit-Position: refs/heads/master@{#398788}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -289 lines) Patch
M cc/ipc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + cc/ipc/quads.mojom View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M components/mus/public/cpp/surfaces/custom_surface_converter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.h View 3 chunks +14 lines, -13 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 1 15 chunks +44 lines, -44 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 8 chunks +36 lines, -36 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/interfaces/compositor_frame.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
D components/mus/public/interfaces/quads.mojom View 1 1 chunk +0 lines, -167 lines 0 comments Download
M components/mus/ws/platform_display.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
Fady Samuel
+ben@ for move out of mus. +tsepez for ipc (no changes).
4 years, 6 months ago (2016-06-08 19:34:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056483002/1
4 years, 6 months ago (2016-06-08 20:02:54 UTC) #6
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-08 20:03:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 21:19:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056483002/1
4 years, 6 months ago (2016-06-08 21:48:59 UTC) #11
commit-bot: I haz the power
Failed to apply patch for cc/ipc/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-08 21:55:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056483002/20001
4 years, 6 months ago (2016-06-09 03:30:26 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/150351)
4 years, 6 months ago (2016-06-09 03:46:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056483002/20001
4 years, 6 months ago (2016-06-09 03:48:00 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 04:56:34 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 04:59:14 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10bd63df0dbbc74da797c7d919d8c5461e947ff5
Cr-Commit-Position: refs/heads/master@{#398788}

Powered by Google App Engine
This is Rietveld 408576698