Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2056213002: Add tests for retargeted event.target in LayoutTests/shadow-dom/ (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@events-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for retargeted event.target in LayoutTests/shadow-dom/ Update dispatchEventWithLog(...) function in LayoutTests/shadow-dom/shadow-dom.js to verify event.target value, which should be the result of a retargeting. BUG=531990 Committed: https://crrev.com/26fa45d0791282493fec1c0f83591440d97d57ae Cr-Commit-Position: refs/heads/master@{#400114}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/event-composed.html View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-composed-path.html View 1 11 chunks +68 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-path-related-target-scoped.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js View 5 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/v0/event-composed-path.html View 1 chunk +10 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056213002/1
4 years, 6 months ago (2016-06-10 09:11:01 UTC) #2
hayato
PTAL
4 years, 6 months ago (2016-06-10 09:15:59 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 10:21:03 UTC) #8
tkent
lgtm
4 years, 6 months ago (2016-06-15 13:10:47 UTC) #9
hayato
rebased
4 years, 6 months ago (2016-06-16 06:20:46 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056213002/20001
4 years, 6 months ago (2016-06-16 06:20:51 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2058673002 Patch 40001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-16 06:21:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056213002/20001
4 years, 6 months ago (2016-06-16 08:04:40 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 08:58:45 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 08:58:57 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 09:00:04 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26fa45d0791282493fec1c0f83591440d97d57ae
Cr-Commit-Position: refs/heads/master@{#400114}

Powered by Google App Engine
This is Rietveld 408576698