Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053353002:
Add tests for an event with a related target (Closed)
DescriptionAdd tests for an event with a related target
Make the test more comprehensive and readable.
BUG=531990
Committed: https://crrev.com/9c0f1ad1c7707a5790edb008ce49080786b685e6
Cr-Commit-Position: refs/heads/master@{#400121}
Patch Set 1 #Patch Set 2 : re #
Total comments: 9
Patch Set 3 : Add more description #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 24 (10 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053353002/1
Description was changed from ========== Test for an event path for an event with related target Rewrite the test more comprehensive and redable. BUG=531990 ========== to ========== Add tests for an event with a related target Make the test more comprehensive and readable. BUG=531990 ==========
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
re
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053353002/20001
hayato@chromium.org changed reviewers: + kochi@chromium.org, tkent@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
lgtm https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html (right): https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:18: }, 'Event Path test1-1'); Please make it more descriptive like test1-2. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:120: }, 'Event Path test3-1'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:130: }, 'Event Path test3-2'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:136: }, 'Event Path test3-3'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:159: }, 'Event Path test4-1'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:169: }, 'Event Path test4-2'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:230: }, 'Event Path test5-1'); Ditto. https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:253: }, 'Event Path test5-2'); Ditto.
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Add more description
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053353002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html (right): https://codereview.chromium.org/2053353002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/shadow-dom/event-composed-path-with-related-target.html:18: }, 'Event Path test1-1'); Done. I have made every tests more descriptive.
The CQ bit was checked by hayato@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2053353002/#ps40001 (title: "Add more description")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053353002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Add tests for an event with a related target Make the test more comprehensive and readable. BUG=531990 ========== to ========== Add tests for an event with a related target Make the test more comprehensive and readable. BUG=531990 Committed: https://crrev.com/9c0f1ad1c7707a5790edb008ce49080786b685e6 Cr-Commit-Position: refs/heads/master@{#400121} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9c0f1ad1c7707a5790edb008ce49080786b685e6 Cr-Commit-Position: refs/heads/master@{#400121} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
